Skip to content

[3.11] gh-108791: Fix pdb CLI invalid argument handling (GH-108816) #111063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 2 commits into from
Oct 19, 2023
Merged

[3.11] gh-108791: Fix pdb CLI invalid argument handling (GH-108816) #111063

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cce79f
[3.11] gh-108791: Fix `pdb` CLI invalid argument handling (GH-108816)
chgnrdv Oct 16, 2023
3527d43
reverted argparse-related changes in test
chgnrdv Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
reverted argparse-related changes in test
  • Loading branch information
@chgnrdv
chgnrdv committed Oct 19, 2023
commit 3527d433e05e37c27ac767ffc54adf1f2b29f2f2
8 changes: 4 additions & 4 deletions Lib/test/test_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2188,10 +2188,10 @@ def test_dir_as_script(self):
self.assertIn(f"Error: {temp_dir} is a directory", stdout)

def test_invalid_cmd_line_options(self):
stdout, stderr = self._run_pdb(["-c"], "", expected_returncode=2)
self.assertIn(f"pdb: error: argument -c/--command: expected one argument", stdout.split('\n')[1])
stdout, stderr = self._run_pdb(["--spam", "-m", "pdb"], "", expected_returncode=2)
self.assertIn(f"pdb: error: unrecognized arguments: --spam", stdout.split('\n')[1])
stdout, stderr = self._run_pdb(["-c"], "", expected_returncode=1)
self.assertIn(f"Error: option -c requires argument", stdout)
stdout, stderr = self._run_pdb(["--spam"], "", expected_returncode=1)
self.assertIn(f"Error: option --spam not recognized", stdout)

def test_blocks_at_first_code_line(self):
script = """
Expand Down