Skip to content

gh-111495: Add tests for PyComplex C API #111591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 16 commits into from
Nov 5, 2023
Merged

gh-111495: Add tests for PyComplex C API #111591

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b88f657
gh-111495: Add tests for PyComplex C API
skirpichev Nov 1, 2023
9f04bcb
Simplify complex_fromdoubles()
skirpichev Nov 1, 2023
d19a9d4
Use assertEqual()
skirpichev Nov 1, 2023
c8adbd2
Move tests to Lib/test/test_capi/test_complex.py
skirpichev Nov 1, 2023
6ead74b
Add missing coverage tests
skirpichev Nov 2, 2023
67fb214
Cleanup, add comments
skirpichev Nov 2, 2023
7694c60
Apply suggestions from code review
skirpichev Nov 4, 2023
70796bd
+1
skirpichev Nov 4, 2023
5c1cd4f
Correct typos and wrongly added test
skirpichev Nov 4, 2023
20e37e5
Drop comments
skirpichev Nov 4, 2023
b743f4b
Use PyComplex_AsCComplex() in complex_fromccomplex()
skirpichev Nov 4, 2023
89a18ff
Merge branch 'main' into capi-complex-tests
skirpichev Nov 4, 2023
34347fa
Use PyArg_Parse('D') instead
skirpichev Nov 4, 2023
09f5246
s/3.14/4.25/g
skirpichev Nov 5, 2023
3682e51
Reorder statements in test_as* and add an integer test for imagasdoub…
skirpichev Nov 5, 2023
a4981d6
Apply suggestions from code review
serhiy-storchaka Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
s/3.14/4.25/g
  • Loading branch information
@skirpichev
skirpichev committed Nov 5, 2023
commit 09f52463b8b7e35c220ca7515a3be4e8ee660d2d
12 changes: 6 additions & 6 deletions Lib/test/test_capi/test_complex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ def test_realasdouble(self):
self.assertEqual(realasdouble(-1.0), -1.0)

self.assertEqual(realasdouble(ComplexSubclass(1+2j)), 1.0)
self.assertEqual(realasdouble(3.14), 3.14)
self.assertEqual(realasdouble(FloatSubclass(3.14)), 3.14)
self.assertEqual(realasdouble(4.25), 4.25)
self.assertEqual(realasdouble(FloatSubclass(4.25)), 4.25)

# Test types with __complex__ dunder method
# Function doesn't support classes with __complex__ dunder, see #109598
Expand All @@ -91,8 +91,8 @@ def test_imagasdouble(self):
self.assertEqual(imagasdouble(1+2j), 2.0)
self.assertEqual(imagasdouble(1-1j), -1.0)
self.assertEqual(imagasdouble(ComplexSubclass(1+2j)), 2.0)
self.assertEqual(imagasdouble(3.14), 0.0)
self.assertEqual(imagasdouble(FloatSubclass(3.14)), 0.0)
self.assertEqual(imagasdouble(4.25), 0.0)
self.assertEqual(imagasdouble(FloatSubclass(4.25)), 0.0)

# Test types with __complex__ dunder method
# Function doesn't support classes with __complex__ dunder, see #109598
Expand All @@ -110,8 +110,8 @@ def test_asccomplex(self):
# Test subclasses of complex/float
self.assertEqual(asccomplex(1+2j), 1.0+2.0j)
self.assertEqual(asccomplex(ComplexSubclass(1+2j)), 1.0+2.0j)
self.assertEqual(asccomplex(3.14), 3.14+0.0j)
self.assertEqual(asccomplex(FloatSubclass(3.14)), 3.14+0.0j)
self.assertEqual(asccomplex(4.25), 4.25+0.0j)
self.assertEqual(asccomplex(FloatSubclass(4.25)), 4.25+0.0j)

# Test types with __complex__ dunder method
self.assertEqual(asccomplex(Complex()), 4.25+0.5j)
Expand Down