Skip to content

gh-112334: Restore subprocess's use of vfork() & fix extra_groups=[] behavior #112617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 4 commits into from
Dec 4, 2023
+38 −23
Merged

gh-112334: Restore subprocess's use of vfork() & fix extra_groups=[] behavior #112617

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a896fc
gh-112334: Restore subprocess's use of `vfork()` & fix `extra_groups=…
gpshead Dec 2, 2023
84d060f
Code Health (remove a compiler warning).
gpshead Dec 2, 2023
52a475c
Improve the assertion.
gpshead Dec 4, 2023
ce31462
Fix the refactored test to not override parameters.
gpshead Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code Health (remove a compiler warning).
  • Loading branch information
@gpshead
gpshead committed Dec 2, 2023
commit 84d060f0af01c5e6e3392095e62be621f95704f3
2 changes: 1 addition & 1 deletion Modules/_posixsubprocess.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ child_exec(char *const exec_array[],

#ifdef HAVE_SETGROUPS
if (extra_group_size >= 0) {
assert(extra_group_size == 0 && extra_groups == NULL || extra_group_size);
assert((extra_group_size == 0 && extra_groups == NULL) || extra_group_size);
POSIX_CALL(setgroups(extra_group_size, extra_groups));
}
#endif /* HAVE_SETGROUPS */
Expand Down