gh-115347: avoid emitting redundant NOP for the docstring with -OO#115494
Merged
iritkatriel merged 2 commits intopython:mainfrom Feb 15, 2024
Merged
gh-115347: avoid emitting redundant NOP for the docstring with -OO#115494iritkatriel merged 2 commits intopython:mainfrom
iritkatriel merged 2 commits intopython:mainfrom
Conversation
markshannon
approved these changes
Feb 15, 2024
Member
markshannon
left a comment
There was a problem hiding this comment.
Looks good.
I can't help thinking that extracting the docstring is the parser's or symbol table generator's job. Probably not worth the effort to change it though.
Member
Author
Note that you can call |
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115347.