Skip to content

gh-115999: Disable the specializing adaptive interpreter in free-threaded builds #116013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 7 commits into from
Mar 1, 2024
Merged

gh-115999: Disable the specializing adaptive interpreter in free-threaded builds #116013

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3eff0b1
Disable the specializing adaptive interpreter in free-threaded builds
swtaarrs Feb 27, 2024
c98987b
Forgot to make regen-cases again
swtaarrs Feb 27, 2024
20b081c
Mark some tests that require specialization
swtaarrs Feb 28, 2024
a3ecd16
Merge remote-tracking branch 'upstream/main' into cpython-nogil-inter…
swtaarrs Feb 29, 2024
db4f433
Disable more tests
swtaarrs Feb 29, 2024
4c4400a
Make DECREMENT_ADAPTIVE_COUNTER fail at compile time
swtaarrs Feb 29, 2024
53cefbc
Merge remote-tracking branch 'upstream/main' into cpython-nogil-inter…
swtaarrs Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make DECREMENT_ADAPTIVE_COUNTER fail at compile time
  • Loading branch information
@swtaarrs
swtaarrs committed Feb 29, 2024
commit 4c4400abdecf8aefdbffec6186a95961bf0d8f52
8 changes: 4 additions & 4 deletions Python/ceval_macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,10 @@ GETITEM(PyObject *v, Py_ssize_t i) {
(((COUNTER) >> ADAPTIVE_BACKOFF_BITS) == ((1 << MAX_BACKOFF_VALUE) - 1))

#ifdef Py_GIL_DISABLED
#define DECREMENT_ADAPTIVE_COUNTER(COUNTER) \
do { \
/* gh-115999 tracks progress on addressing this. */ \
Py_FatalError("The adaptive interpreter is not thread-safe"); \
#define DECREMENT_ADAPTIVE_COUNTER(COUNTER) \
do { \
/* gh-115999 tracks progress on addressing this. */ \
static_assert(0, "The specializing interpreter is not yet thread-safe"); \
} while (0);
#else
#define DECREMENT_ADAPTIVE_COUNTER(COUNTER) \
Expand Down