Skip to content

gh-108901: Add bound_arg to Signature.from_callable() and signature() #116559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sobolevn wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-108901: Add bound_arg to Signature.from_callable() and signature() #116559

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
290e1ad
gh-108901: Add `skip_bound_arg` to `Signature.from_callable()` and `s…
sobolevn Mar 10, 2024
2e36181
Update Doc/whatsnew/3.13.rst
sobolevn Mar 10, 2024
a0ed116
Address review
sobolevn Mar 10, 2024
470625f
Update docs
sobolevn Mar 10, 2024
8f6424a
Show the signature change in test
sobolevn Mar 11, 2024
4f08ab7
Simply example
sobolevn Mar 11, 2024
d76ba71
Improve readability
sobolevn Mar 11, 2024
e30aeb2
Merge branch 'main' into issue-108901-add-getfullargspec
sobolevn Apr 24, 2024
4d5a96e
Rename `skip_bound_arg` to `bound_arg`
sobolevn Apr 24, 2024
3b884eb
Mention `inspect313`
sobolevn Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mention inspect313
  • Loading branch information
@sobolevn
sobolevn committed Apr 24, 2024
commit 3b884ebba607d6f9207e08091326e7248b01f88e
1 change: 1 addition & 0 deletions Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,7 @@ inspect
* Add *bound_arg* parameter to :func:`inspect.Signature.from_callable`
and :func:`inspect.signature`: keep the ``self`` parameter
in the method signature if *bound_arg* is True.
Copy link
Copy Markdown
Contributor

@ncoghlan ncoghlan Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reword here to match the updated main function docs (including mentioning the getfullargspec compatibility)

:pypi:`inspect313` package has a backport of this feature.
Copy link
Copy Markdown
Contributor

@ncoghlan ncoghlan Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make the backport mention a seealso note in the module docs rather than only putting it here?

(Contributed by Nikita Sobolev in :gh:`108901`.)

ipaddress
Expand Down