Skip to content

gh-96471: Correct documentation for asyncio queue shutdown #117621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 3 commits into from
Apr 8, 2024
Merged

gh-96471: Correct documentation for asyncio queue shutdown #117621

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5d0416
Comment reason for waking up getters after shutdown
EpicWink Apr 4, 2024
5b41217
Mention gets are always unblocked
EpicWink Apr 8, 2024
d0d5d6d
Acknowledge Yves D
EpicWink Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Comment reason for waking up getters after shutdown
  • Loading branch information
@EpicWink
EpicWink committed Apr 8, 2024
commit c5d041623672a4a52a2f083db08fa6ac38883f8a
1 change: 1 addition & 0 deletions Lib/asyncio/queues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ def shutdown(self, immediate=False):
self._unfinished_tasks -= 1
if self._unfinished_tasks == 0:
self._finished.set()
# All getters need to re-check queue-empty to raise ShutDown
while self._getters:
getter = self._getters.popleft()
if not getter.done():
Expand Down