Skip to content

gh-117641: Use set comprehension for posixpath.commonpath() #117652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 8 commits into from
Apr 18, 2024
Merged

gh-117641: Use set comprehension for posixpath.commonpath() #117652

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b98a404
Use set comprehension for `posixpath.commonpath()`
nineteendo Apr 8, 2024
a9a7161
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 8, 2024
a9bf9b6
replace startswith with slice comparison
nineteendo Apr 9, 2024
4597fbf
Revert "replace startswith with slice comparison"
nineteendo Apr 9, 2024
d98a69a
Update 2024-04-08-19-30-38.gh-issue-117641.oaBGSJ.rst
nineteendo Apr 9, 2024
1f12063
Update 2024-04-08-19-30-38.gh-issue-117641.oaBGSJ.rst
nineteendo Apr 11, 2024
98674d5
Revert unpacking
nineteendo Apr 16, 2024
928247a
Merge branch 'main' into speedup-posixpath.commonpath
nineteendo Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert unpacking
  • Loading branch information
@nineteendo
nineteendo committed Apr 16, 2024
commit 98674d592b8bd762178e532f7547aa1e4c5dae79
8 changes: 5 additions & 3 deletions Lib/posixpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,8 +558,10 @@ def commonpath(paths):
try:
split_paths = [path.split(sep) for path in paths]

if len({p.startswith(sep) for p in paths}) != 1:
raise ValueError("Can't mix absolute and relative paths")
try:
isabs, = {p.startswith(sep) for p in paths}
except ValueError:
raise ValueError("Can't mix absolute and relative paths") from None

split_paths = [[c for c in s if c and c != curdir] for s in split_paths]
s1 = min(split_paths)
Expand All @@ -570,7 +572,7 @@ def commonpath(paths):
common = s1[:i]
break

prefix = sep if paths[0].startswith(sep) else sep[:0]
prefix = sep if isabs else sep[:0]
return prefix + sep.join(common)
except (TypeError, AttributeError):
genericpath._check_arg_types('commonpath', *paths)
Expand Down