gh-117663: [Enum] fix _simple_enum's detection of aliases#117664
gh-117663: [Enum] fix _simple_enum's detection of aliases#117664ethanfurman merged 3 commits intopython:mainfrom
Conversation
| def __new__(cls, value, phrase, description=''): | ||
| obj = int.__new__(cls, value) | ||
| obj._value_ = value | ||
|
|
There was a problem hiding this comment.
This whitespace change can probably be omitted?
There was a problem hiding this comment.
In theory, but the blank line irritates me. :)
There was a problem hiding this comment.
Maybe I'm nitpicking, but that means you're making a change to HTTPStatus while this PR is not about HTTPStatus but about Enums. It's a whitespace change, but still.. I've made it now part of my PR https://github.com/python/cpython/pull/117611/files which already changes the file Lib/http/__init__.py -- so you can drop it from this PR if you want.
There was a problem hiding this comment.
Fair point. Change removed.
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @ethanfurman, I could not cleanly backport this to |
Fix
_simple_enumto detect aliases when multiple arguments are present but only one is the member value.