Skip to content

gh-117995: Don't raise DeprecationWarnings for indexed nameless params#118001

Merged
erlend-aasland merged 4 commits intopython:mainfrom
erlend-aasland:sqlite/indexed-nameless-placeholder
Apr 22, 2024
Merged

gh-117995: Don't raise DeprecationWarnings for indexed nameless params#118001
erlend-aasland merged 4 commits intopython:mainfrom
erlend-aasland:sqlite/indexed-nameless-placeholder

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 17, 2024 •
edited
Loading

Filter out ?NNN type placeholders when looking for named params.

@erlend-aasland
pythongh-117995: Don't raise DeprecationWarnings for indexed nameless…
f0ddf10 
… params

Filter out '?NNN' type placeholders when looking for named params.
@erlend-aasland erlend-aasland added the needs backport to 3.12 only security fixes label Apr 17, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 17, 2024
Closed
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 17, 2024

cc. @kalekundert

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 17, 2024

@aisk, would you like to review this?

aisk
aisk reviewed Apr 18, 2024
View reviewed changes
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 18, 2024

I'll merge this early next week. Thanks for chiming in, @aisk :)

@erlend-aasland erlend-aasland self-assigned this Apr 18, 2024
@erlend-aasland erlend-aasland requested a review from aisk April 18, 2024 14:45
aisk
aisk reviewed Apr 18, 2024
View reviewed changes
@erlend-aasland @aisk
Update test_dbapi.py
5be9a02 
Co-authored-by: AN Long <aisk@users.noreply.github.com>
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 18, 2024

Thank you so much, @aisk!

felixxm
felixxm approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland Thanks 👍 Looks good 🚀

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 22, 2024

Thanks for the review, Mariusz!

@erlend-aasland erlend-aasland merged commit 550483b into python:main Apr 22, 2024
@erlend-aasland erlend-aasland deleted the sqlite/indexed-nameless-placeholder branch April 22, 2024 06:43
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2024
@erlend-aasland @aisk @miss-islington
pythongh-117995: Don't raise DeprecationWarnings for indexed nameless…
836f649 
… params (pythonGH-118001)

Filter out '?NNN' placeholders when looking for named params.

(cherry picked from commit 550483b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 22, 2024

GH-118142 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 22, 2024
erlend-aasland added a commit that referenced this pull request Apr 22, 2024
@miss-islington @erlend-aasland @aisk
[3.12] gh-117995: Don't raise DeprecationWarnings for indexed nameles…
9ddaf75 
…s params (GH-118001) (#118142)

Filter out '?NNN' placeholders when looking for named params.

(cherry picked from commit 550483b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 22, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL7 LTO + PGO 3.x has failed when building commit 550483b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/43/builds/5265) and take a look at the build logs.
  4. Check if the failure is related to this commit (550483b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/43/builds/5265

Failed tests:

  • test_capi

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 26, done.        
remote: Counting objects:   3% (1/26)        
remote: Counting objects:   7% (2/26)        
remote: Counting objects:  11% (3/26)        
remote: Counting objects:  15% (4/26)        
remote: Counting objects:  19% (5/26)        
remote: Counting objects:  23% (6/26)        
remote: Counting objects:  26% (7/26)        
remote: Counting objects:  30% (8/26)        
remote: Counting objects:  34% (9/26)        
remote: Counting objects:  38% (10/26)        
remote: Counting objects:  42% (11/26)        
remote: Counting objects:  46% (12/26)        
remote: Counting objects:  50% (13/26)        
remote: Counting objects:  53% (14/26)        
remote: Counting objects:  57% (15/26)        
remote: Counting objects:  61% (16/26)        
remote: Counting objects:  65% (17/26)        
remote: Counting objects:  69% (18/26)        
remote: Counting objects:  73% (19/26)        
remote: Counting objects:  76% (20/26)        
remote: Counting objects:  80% (21/26)        
remote: Counting objects:  84% (22/26)        
remote: Counting objects:  88% (23/26)        
remote: Counting objects:  92% (24/26)        
remote: Counting objects:  96% (25/26)        
remote: Counting objects: 100% (26/26)        
remote: Counting objects: 100% (26/26), done.        
remote: Compressing objects:   7% (1/14)        
remote: Compressing objects:  14% (2/14)        
remote: Compressing objects:  21% (3/14)        
remote: Compressing objects:  28% (4/14)        
remote: Compressing objects:  35% (5/14)        
remote: Compressing objects:  42% (6/14)        
remote: Compressing objects:  50% (7/14)        
remote: Compressing objects:  57% (8/14)        
remote: Compressing objects:  64% (9/14)        
remote: Compressing objects:  71% (10/14)        
remote: Compressing objects:  78% (11/14)        
remote: Compressing objects:  85% (12/14)        
remote: Compressing objects:  92% (13/14)        
remote: Compressing objects: 100% (14/14)        
remote: Compressing objects: 100% (14/14), done.        
remote: Total 14 (delta 12), reused 2 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch            main       -> FETCH_HEAD
Note: checking out '550483b7e6c54b2a25d4db0c4ca41bd9c1132f93'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 550483b... gh-117995: Don't raise DeprecationWarnings for indexed nameless params (#118001)
Switched to and reset branch 'main'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3082: clean-retain-profile] Error 1 (ignored)
Python/Python-ast.c: In function ‘init_types’:
Python/Python-ast.c:5478:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 init_types(struct ast_state *state)
 ^~~~~~~~~~
./Modules/_testlimitedcapi/unicode.c: In function ‘test_string_from_format’:
./Modules/_testlimitedcapi/unicode.c:1416:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 test_string_from_format(PyObject *self, PyObject *Py_UNUSED(ignored))
 ^~~~~~~~~~~~~~~~~~~~~~~
./Modules/_testlimitedcapi/unicode.c: In function ‘test_string_from_format’:
./Modules/_testlimitedcapi/unicode.c:1416:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 test_string_from_format(PyObject *self, PyObject *Py_UNUSED(ignored))
 ^
Python/Python-ast.c: In function ‘init_types’:
Python/Python-ast.c:5478:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 init_types(struct ast_state *state)
 ^
Python/Python-ast.c: In function ‘init_types’:
Python/Python-ast.c:5478:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 init_types(struct ast_state *state)
 ^
Python/Python-ast.c: In function ‘init_types’:
Python/Python-ast.c:5478:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 init_types(struct ast_state *state)
 ^

make: *** [Makefile:2229: buildbottest] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

+1 more reviewer

@felixxm felixxm felixxm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @aisk @felixxm