gh-118090: Improve error message for empty type param brackets#118091
Merged
encukou merged 8 commits intopython:mainfrom May 7, 2024
Merged
gh-118090: Improve error message for empty type param brackets#118091encukou merged 8 commits intopython:mainfrom
encukou merged 8 commits intopython:mainfrom
Conversation
AlexWaygood
reviewed
Apr 19, 2024
Member
Author
|
Ubuntu failures are unrelated: connection timeout. |
Member
there's also a failure about generated files not being up to date, though, which looks real ;) |
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks! Left a suggestion for improving the error.
JelleZijlstra
approved these changes
Apr 19, 2024
Member
Author
|
Thanks for the review! I will also wait for @pablogsal or @lysnikolaou review as code owners :) |
pablogsal
reviewed
Apr 23, 2024
lysnikolaou
approved these changes
Apr 29, 2024
Member
lysnikolaou
left a comment
There was a problem hiding this comment.
LGTM! Makes sense we had to remove the forced token stuff from the first pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
class A[]: ...syntax error message #118090