Skip to content

gh-118218: Reuse return tuple in itertools.pairwise #118219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 5 commits into from
Apr 30, 2024
Merged

gh-118218: Reuse return tuple in itertools.pairwise #118219

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bd6a58
gh-118218: Reuse return tuple in itertools.pairwise
hauntsaninja Apr 24, 2024
f653f22
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 24, 2024
ea0cfd6
add bpo-42536 style test for gc tracking
hauntsaninja Apr 24, 2024
68b5d27
nit
hauntsaninja Apr 28, 2024
1bfddd6
Update Misc/NEWS.d/next/Library/2024-04-24-07-45-08.gh-issue-118218.m…
hauntsaninja Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add bpo-42536 style test for gc tracking
  • Loading branch information
@hauntsaninja
hauntsaninja committed Apr 24, 2024
commit ea0cfd6759e0a10cc557984ff40446c7fc30e6c0
7 changes: 7 additions & 0 deletions Lib/test/test_itertools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1821,6 +1821,13 @@ def test_zip_longest_result_gc(self):
gc.collect()
self.assertTrue(gc.is_tracked(next(it)))

@support.cpython_only
def test_pairwise_result_gc(self):
# Ditto for pairwise.
it = pairwise([None, None])
gc.collect()
Comment on lines +1827 to +1828
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all tests above except for zip_longest there is a next(it) before gc.collect(). All these tests were added in 226a012 (bpo-42536).

@brandtbucher, why is such difference? Is there a bug in test_zip_longest_result_gc? Do we need next(it) there and here?

self.assertTrue(gc.is_tracked(next(it)))

@support.cpython_only
def test_immutable_types(self):
from itertools import _grouper, _tee, _tee_dataobject
Expand Down