pathlib ABCs: remove duplicate realpath() implementation.#119178
Merged
barneygale merged 7 commits intopython:mainfrom Jun 5, 2024
Merged
pathlib ABCs: remove duplicate realpath() implementation.#119178barneygale merged 7 commits intopython:mainfrom
realpath() implementation.#119178barneygale merged 7 commits intopython:mainfrom
Conversation
Add private `posixpath._realpath()` function, which is a generic version of `realpath()` that can be parameterised with string tokens (`sep`, `curdir`, `pardir`) and query functions (`getcwd`, `lstat`, `readlink`). Also add support for limiting the number of symlink traversals. In the private `pathlib._abc.PathBase` class, call `posixpath._realpath()` and remove our re-implementation of the same algorithm. This speeds up `PathBase.resolve()` because we instantiate fewer `PathBase` objects, and because `_realpath()` caches symlink targets.
nineteendo
reviewed
May 19, 2024
nineteendo
reviewed
May 19, 2024
nineteendo
reviewed
May 22, 2024
nineteendo
reviewed
May 31, 2024
Contributor
nineteendo
left a comment
There was a problem hiding this comment.
Don't hard code the error message, like eryksun pointed out in the other pull request.
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
…19178) Add private `posixpath._realpath()` function, which is a generic version of `realpath()` that can be parameterised with string tokens (`sep`, `curdir`, `pardir`) and query functions (`getcwd`, `lstat`, `readlink`). Also add support for limiting the number of symlink traversals. In the private `pathlib._abc.PathBase` class, call `posixpath._realpath()` and remove our re-implementation of the same algorithm. No change to any public APIs, either in `posixpath` or `pathlib`. Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Contributor
Author
|
Will backport to make backporting #120127 easier. |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
2 similar comments
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @barneygale, I could not cleanly backport this to |
Contributor
Author
|
Ah foo, nevermind then! |
|
Sorry, @barneygale, I could not cleanly backport this to |
|
Sorry, @barneygale, I could not cleanly backport this to |
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…19178) Add private `posixpath._realpath()` function, which is a generic version of `realpath()` that can be parameterised with string tokens (`sep`, `curdir`, `pardir`) and query functions (`getcwd`, `lstat`, `readlink`). Also add support for limiting the number of symlink traversals. In the private `pathlib._abc.PathBase` class, call `posixpath._realpath()` and remove our re-implementation of the same algorithm. No change to any public APIs, either in `posixpath` or `pathlib`. Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…19178) Add private `posixpath._realpath()` function, which is a generic version of `realpath()` that can be parameterised with string tokens (`sep`, `curdir`, `pardir`) and query functions (`getcwd`, `lstat`, `readlink`). Also add support for limiting the number of symlink traversals. In the private `pathlib._abc.PathBase` class, call `posixpath._realpath()` and remove our re-implementation of the same algorithm. No change to any public APIs, either in `posixpath` or `pathlib`. Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add private
posixpath._realpath()function, which is a generic version ofrealpath()that can be parameterised with string tokens (sep,curdir,pardir) and query functions (getcwd,lstat,readlink). Also add support for limiting the number of symlink traversals.In the private
pathlib._abc.PathBaseclass, callposixpath._realpath()and remove our re-implementation of the same algorithm. This speeds upPathBase.resolve()because we instantiate fewerPathBaseobjects, and because_realpath()caches symlink targets.No change to any public APIs, either in
posixpathorpathlib.