Skip to content

GH-119169: Speed up os.walk(topdown=False) #119186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barneygale wants to merge 12 commits into from
Closed

GH-119169: Speed up os.walk(topdown=False) #119186

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
74a495c
GH-119169: Speed up `os.walk()`
barneygale May 19, 2024
eb4b6ff
Merge branch 'main' into os-walk-speedup
barneygale May 23, 2024
46a3ba5
Simplify bottom-up implementation.
barneygale May 23, 2024
2d957a8
Merge branch 'main' into os-walk-speedup
barneygale May 30, 2024
a638202
Apply the same changes to fwalk()
barneygale May 30, 2024
91b5a78
Simplify code slightly
barneygale May 30, 2024
b32c1c0
Simplify exception handling in fwalk()
barneygale Jul 6, 2024
8c7cf04
Merge branch 'main' into os-walk-speedup
barneygale Jul 6, 2024
efd31e2
Undo trailing slash optimisation (moved to another PR)
barneygale Jul 6, 2024
5b89c57
Undo fwalk() changes.
barneygale Jul 6, 2024
525618c
Fix news entry.
barneygale Jul 6, 2024
d3af655
Merge branch 'main' into os-walk-speedup
barneygale Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into os-walk-speedup
  • Loading branch information
@barneygale
barneygale committed May 30, 2024
commit 2d957a8474ff0979fe8056275d3f208c46732103
10 changes: 6 additions & 4 deletions Lib/os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,12 +371,14 @@ def walk(top, topdown=True, onerror=None, followlinks=False):
for entry in entries:
is_dir = False
try:
if entry.is_dir():
is_dir = True
if followlinks is _walk_symlinks_as_files:
is_dir = entry.is_dir(follow_symlinks=False) and not entry.is_junction()
else:
is_dir = entry.is_dir()
if is_dir and not topdown and (followlinks or not entry.is_symlink()):
# Bottom-up: traverse into sub-directory, but exclude
# symlinks to directories if followlinks is False
if not topdown and (followlinks or not entry.is_symlink()):
stack.append(entry.path)
stack.append(entry.path)
except OSError:
# If is_dir() raises an OSError, consider the entry not to
# be a directory, same behaviour as os.path.isdir().
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.