Skip to content

gh-119011: Return an empty tuple on type_get_type_params as special case for PyType_Type#119313

Closed
mdkcore0 wants to merge 2 commits intopython:mainfrom
mdkcore0:gh-119011
Closed

gh-119011: Return an empty tuple on type_get_type_params as special case for PyType_Type#119313
mdkcore0 wants to merge 2 commits intopython:mainfrom
mdkcore0:gh-119011

Conversation

@mdkcore0
Copy link
Contributor

@mdkcore0 mdkcore0 commented May 21, 2024 •
edited by bedevere-app bot
Loading

First pull-request for cpython; fixes an issue where functools.update_wrapper was not returning a tuple for __type_params__.

@mdkcore0 mdkcore0 requested a review from markshannon as a code owner May 21, 2024 14:57
@ghost
Copy link

ghost commented May 21, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request May 21, 2024
Closed
@mdkcore0
Copy link
Contributor Author

mdkcore0 commented May 21, 2024 •
edited
Loading

It would like to add some tests for this, as it is my first contribution, any directions on how to do that?
Thanks!

carljm
carljm approved these changes May 21, 2024
View reviewed changes
carljm
carljm requested changes May 21, 2024
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Would it be possible to add a test for this?

@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@carljm
Copy link
Member

carljm commented May 21, 2024

Sorry, it looks like @sobolevn beat you to this one: #119296

@carljm carljm closed this May 21, 2024
@mdkcore0 mdkcore0 deleted the gh-119011 branch May 21, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm requested changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdkcore0 @carljm