Skip to content

gh-119105: Differ.compare is too slow [for degenerate cases] #119492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-one merged 13 commits into from
May 25, 2024
Merged

gh-119105: Differ.compare is too slow [for degenerate cases] #119492

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e77d0fe
WIP - many problems.
tim-one May 23, 2024
10078a5
Merge remote-tracking branch 'upstream/main' into differ
tim-one May 24, 2024
5eeeef5
`_fancy_replace()` is no longer recursive. Instead it uses a sliding …
tim-one May 24, 2024
8e93248
Merge remote-tracking branch 'upstream/main' into differ
tim-one May 24, 2024
ff38977
📜🤖 Added by blurb_it.
blurb-it[bot] May 24, 2024
1a0426d
move a line; add some comments
tim-one May 24, 2024
2be9b49
Merge branch 'differ' of https://github.com/tim-one/cpython into differ
tim-one May 24, 2024
c187ce1
Fix the windowing code to be symmetric.
tim-one May 24, 2024
f8af107
Merge remote-tracking branch 'upstream/main' into differ
tim-one May 24, 2024
25904d6
Minor fiddling.
tim-one May 24, 2024
4e5af7d
Merge remote-tracking branch 'upstream/main' into differ
tim-one May 24, 2024
55d54b0
Merge remote-tracking branch 'upstream/main' into differ
tim-one May 25, 2024
d6a8c31
Beef up the NEWS entry.
tim-one May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-05-24-04-05-37.gh-issue-119105.aDSRFn.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
``difflib``'s ``DIffer.compare()`` (and so also ``ndiff``) can no longer be provoked into cubic-time behavior, or into unbounded recursion, and should generally be faster in ordinary cases too. Results may change in some cases, although that should be rare.