bpo-36091: remove reference to async generator in Lib/types.py#11996
Merged
serhiy-storchaka merged 2 commits intopython:masterfrom Mar 3, 2019
Merged
bpo-36091: remove reference to async generator in Lib/types.py#11996serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka merged 2 commits intopython:masterfrom
Conversation
serhiy-storchaka
approved these changes
Mar 3, 2019
Contributor
|
Thanks @scotchka for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2019
…onGH-11996) (cherry picked from commit 0a6a412) Co-authored-by: Henry Chen <tahafut@gmail.com>
|
GH-12146 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 3, 2019
|
Contributor
Author
|
issue related to buildbot AMD64 FreeBSD CURRENT Shared 3.x failure: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The types module creates an async generator
_agfor the purpose of extracting its type. This causes a GeneratorExit exception upon program exit, as can be seen by running the following script:which outputs
To preempt this, this PR proposes to delete
_agafter getting its type, which is its sole purpose, like several other objects in the types module.https://bugs.python.org/issue36091