Skip to content

gh-120029: make symtable.Symbol.__repr__ correctly reflect the compiler's flags #120099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 26 commits into from
Jun 12, 2024
Merged

gh-120029: make symtable.Symbol.__repr__ correctly reflect the compiler's flags #120099

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ecf13fa
export more flags
picnixz Jun 5, 2024
6b52473
rename private module constant "SCOPE_OFF" -> "SCOPE_OFFSET"
picnixz Jun 5, 2024
4fe8b34
add private Python function mirroring '_PyST_GetScope'
picnixz Jun 5, 2024
73f8dc7
fix some reference in a comment
picnixz Jun 5, 2024
477ad7f
handle exported flags
picnixz Jun 5, 2024
d04b013
add test
picnixz Jun 5, 2024
ff02dfa
add doc
picnixz Jun 5, 2024
5c612de
blurb
picnixz Jun 5, 2024
1e84973
address review
picnixz Jun 6, 2024
388e40e
revert to using `SCOPE_OFF`
picnixz Jun 6, 2024
9a74d6b
fixup new line
picnixz Jun 6, 2024
46f1604
expose ``is_free_class``
picnixz Jun 7, 2024
f853905
un-expose `DEF_FREE`
picnixz Jun 7, 2024
f2ef899
re-blurb
picnixz Jun 7, 2024
c915f04
add test
picnixz Jun 7, 2024
d101a58
fix lint
picnixz Jun 7, 2024
6c450fa
fix indentation
picnixz Jun 7, 2024
c44622b
update NEWS
picnixz Jun 7, 2024
379c368
update CHANGELOG
picnixz Jun 7, 2024
8420820
fix typo
picnixz Jun 7, 2024
ede2a58
fixup
picnixz Jun 7, 2024
9d8dfb4
address review
picnixz Jun 7, 2024
de459bb
fixup
picnixz Jun 7, 2024
5e569ec
Merge branch 'main' into export-symtable-flags
carljm Jun 11, 2024
2cbae12
Merge branch 'main' into export-symtable-flags
picnixz Jun 12, 2024
ac51d69
fix test
picnixz Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@picnixz
picnixz committed Jun 7, 2024
commit c915f04c67ccb7d8fb80200939e6e6b7bc05e1aa
12 changes: 12 additions & 0 deletions Lib/test/test_symtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,18 @@ def test_symbol_repr(self):
self.assertEqual(repr(st2.lookup("x")),
"<symbol 'x': CELL, DEF_LOCAL|DEF_COMP_ITER|DEF_COMP_CELL>")

st3 = symtable.symtable("def f():\n"
" x = 1\n"
" class A:\n"
" x = 2\n"
" def method():\n"
" return x\n",
"?", "exec")
func_f = st3.get_children()[0]
class_A = func_f.get_children()[0]
self.assertEqual(repr(class_A.lookup('x')),
"<symbol 'x': LOCAL, DEF_LOCAL|DEF_FREE_CLASS>")

def test_symtable_entry_repr(self):
expected = f"<symtable entry top({self.top.get_id()}), line {self.top.get_lineno()}>"
self.assertEqual(repr(self.top._table), expected)
Expand Down