Skip to content

gh-120289: Do not free memory in disable() to prevent use-after-free #120297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaogaotiantian merged 14 commits into from
Jul 18, 2024
Merged

gh-120289: Do not free memory in disable() to prevent use-after-free #120297

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
59538ad
Warn if the external timer changes the cprofile context
gaogaotiantian Jun 9, 2024
811b74c
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 9, 2024
df99b2e
Do not free memory when disable
gaogaotiantian Jun 10, 2024
7675efb
We need to check if the context is already put in the free list
gaogaotiantian Jun 10, 2024
e2d68e6
nullify the context pointer instead of use an extra field
gaogaotiantian Jun 11, 2024
b317c67
Update 2024-06-09-19-53-11.gh-issue-120289.s4HXR0.rst
gaogaotiantian Jun 14, 2024
aa5efcd
Update 2024-06-09-19-53-11.gh-issue-120289.s4HXR0.rst
gaogaotiantian Jun 14, 2024
92cb052
Remove restriction to limit the test on ASAN
gaogaotiantian Jun 25, 2024
c5f89b5
Revert changes to lsprof
gaogaotiantian Jul 3, 2024
98e27a9
Revert blank line as well
gaogaotiantian Jul 3, 2024
faa05b1
Disallow disable/clear in external timer
gaogaotiantian Jul 3, 2024
1a44820
Add tests
gaogaotiantian Jul 3, 2024
d59f4c4
Update 2024-06-09-19-53-11.gh-issue-120289.s4HXR0.rst
gaogaotiantian Jul 3, 2024
e76613f
Merge branch 'main' into cprofile-uaf-warning
serhiy-storchaka Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
📜🤖 Added by blurb_it.
  • Loading branch information
@blurb-it
blurb-it[bot] authored Jun 9, 2024
commit 811b74c1708d393d696142715188b794a44903cc
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-06-09-19-53-11.gh-issue-120289.s4HXR0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Generate an unraisable exception if the external timer :mod:`cProfile` uses changes the profile context.
Copy link
Copy Markdown
Member

@markshannon markshannon Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct any more.

Copy link
Copy Markdown
Member Author

@gaogaotiantian gaogaotiantian Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed that. I did not put implementation detail in it because I remember that we are not supposed to do that. So I just said I fixed the issue and mentioned the context.