Skip to content

gh-41431: Add datetime.time.strptime() and datetime.date.strptime() #120752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pganssle merged 19 commits into from
Sep 25, 2024
Merged

gh-41431: Add datetime.time.strptime() and datetime.date.strptime() #120752

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
654af5a
Python implementation
nineteendo Jun 19, 2024
8ba282f
C implementation
nineteendo Jun 19, 2024
24ca6e4
Test `date.strptime`
nineteendo Jun 19, 2024
21a1032
Test `time.strptime`
nineteendo Jun 19, 2024
a06468b
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 19, 2024
34d5b51
Update whatsnew
nineteendo Jun 19, 2024
23b194f
Update documentation
nineteendo Jun 19, 2024
648f414
Add leap year note
nineteendo Jun 19, 2024
c4cbef0
Update 2024-06-19-19-53-42.gh-issue-41431.gnkUc5.rst
nineteendo Jun 24, 2024
a6a2083
Apply suggestions from code review
nineteendo Jun 24, 2024
d7525b4
Remove parentheses
nineteendo Jun 24, 2024
a5486de
Use helper function
nineteendo Jun 24, 2024
f8bcdd3
Remove bad return
nineteendo Jun 24, 2024
ff80f60
Link to github issue
nineteendo Jun 24, 2024
8433545
Merge branch 'main' into add-datetime.strptime
nineteendo Sep 24, 2024
76a0374
Merge branch 'main' into add-datetime.strptime
nineteendo Sep 24, 2024
3f6b729
Fix directive
nineteendo Sep 24, 2024
6cabc24
Apply suggestions from code review
nineteendo Sep 25, 2024
f682985
Fix test cases
nineteendo Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test date.strptime
  • Loading branch information
@nineteendo
nineteendo committed Jun 19, 2024
commit 24ca6e4935cc3fe4f9d32ce7bb1f70edb777e18d
67 changes: 64 additions & 3 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,6 +1109,66 @@ def test_delta_non_days_ignored(self):
dt2 = dt - delta
self.assertEqual(dt2, dt - days)

def test_strptime(self):
string = '2004-12-01'
format = '%Y-%m-%d'
expected = _strptime._strptime_datetime_date(date, string, format)
got = date.strptime(string, format)
self.assertEqual(expected, got)
self.assertIs(type(expected), date)
self.assertIs(type(got), date)

# bpo-34482: Check that surrogates are handled properly.
inputs = [
('2004-12\ud80001', '%Y-%m\ud800%d'),
('2004\ud80012-01', '%Y\ud800%m-%d'),
]
for string, format in inputs:
with self.subTest(string=string, format=format):
expected = _strptime._strptime_datetime_date(date, string,
format)
got = date.strptime(string, format)
self.assertEqual(expected, got)

def test_strptime_single_digit(self):
# bpo-34903: Check that single digit dates are allowed.
strptime = date.strptime
with self.assertRaises(ValueError):
# %y does require two digits.
newdate = strptime('01/02/3', '%d/%m/%y')

d1 = date(2003, 2, 1)
d2 = date(2003, 1, 2)
d3 = date(2003, 2, 1)
d4 = date(2003, 1, 25)
inputs = [
('%d', '1/02/03', '%d/%m/%y', d1),
('%m', '01/2/03', '%d/%m/%y', d1),
('%j', '2/03', '%j/%y', d2),
('%w', '6/04/03', '%w/%U/%y', d3),
# %u requires a single digit.
('%W', '6/4/2003', '%u/%W/%Y', d3),
('%V', '6/4/2003', '%u/%V/%G', d4),
]
for reason, string, format, target in inputs:
reason = 'test single digit ' + reason
with self.subTest(reason=reason,
string=string,
format=format,
target=target):
newdate = strptime(string, format)
self.assertEqual(newdate, target, msg=reason)

@warnings_helper.ignore_warnings(category=DeprecationWarning)
def test_strptime_leap_year(self):
# GH-70647: warns if parsing a format with a day and no year.
with self.assertRaises(ValueError):
# The existing behavior that GH-70647 seeks to change.
date.strptime('02-29', '%m-%d')
with self._assertNotWarns(DeprecationWarning):
date.strptime('20-03-14', '%y-%m-%d')
date.strptime('02-29,2024', '%m-%d,%Y')

class SubclassDate(date):
sub_var = 1

Expand Down Expand Up @@ -2718,7 +2778,8 @@ def test_utcnow(self):
def test_strptime(self):
string = '2004-12-01 13:02:47.197'
format = '%Y-%m-%d %H:%M:%S.%f'
expected = _strptime._strptime_datetime_datetime(self.theclass, string, format)
expected = _strptime._strptime_datetime_datetime(self.theclass, string,
format)
got = self.theclass.strptime(string, format)
self.assertEqual(expected, got)
self.assertIs(type(expected), self.theclass)
Expand All @@ -2732,8 +2793,8 @@ def test_strptime(self):
]
for string, format in inputs:
with self.subTest(string=string, format=format):
expected = _strptime._strptime_datetime_datetime(self.theclass, string,
format)
expected = _strptime._strptime_datetime_datetime(self.theclass,
string, format)
got = self.theclass.strptime(string, format)
self.assertEqual(expected, got)

Expand Down