Skip to content

gh-121940: Reduce checking isatty on Windows write() #121941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmaloney wants to merge 7 commits into from
Closed

gh-121940: Reduce checking isatty on Windows write() #121941

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
485473d
TODO: Stop checking isatty on Windows write()
cmaloney Jul 11, 2024
835eea6
remove more cases
cmaloney Jul 17, 2024
76cc70b
gh-121940: Stop checking isatty on Windows write()
cmaloney Jul 11, 2024
7059c6f
Merge branch 'cmaloney/windows_no_isatty' of ssh://github.com/cmalone…
cmaloney Jul 25, 2024
7adcb0d
gh-121940: Update so write size is limited larger
cmaloney Jul 25, 2024
4b27cdb
Update news
cmaloney Jul 26, 2024
fc8cad2
Fix typo
cmaloney Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Windows/2024-07-17-15-07-24.gh-issue-121940.M70eyc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
``os.write`` on Windows no longer limits or splits up writes to console
objects. The behavior was initially added to address bpo-11395 in 2011 as a
workaround for the OS returning an error with too large of a write call to
a console.
17 changes: 0 additions & 17 deletions Modules/_io/winconsoleio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,23 +134,6 @@ char _PyIO_get_console_type(PyObject *path_or_fd) {
return m;
}

static DWORD
_find_last_utf8_boundary(const char *buf, DWORD len)
{
/* This function never returns 0, returns the original len instead */
DWORD count = 1;
if (len == 0 || (buf[len - 1] & 0x80) == 0) {
return len;
}
for (;; count++) {
if (count > 3 || count >= len) {
return len;
}
if ((buf[len - count] & 0xc0) != 0x80) {
return len - count;
}
}
}

/*[clinic input]
module _io
Expand Down