Skip to content

bpo-35967 resolve platform.processor late #12239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 18 commits into from
Apr 16, 2020
Merged

bpo-35967 resolve platform.processor late #12239

Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e2678d9
Replace flag-flip indirection with direct inspection
jaraco Mar 8, 2019
5d93954
Use any for simpler code
jaraco Mar 8, 2019
df39881
Avoid flag flip and set results directly.
jaraco Mar 8, 2019
da9976a
Resolve processor in a single function.
jaraco Mar 8, 2019
ba99fb5
Extract processor handling into a namespace (class)
jaraco Mar 8, 2019
1385129
Remove _syscmd_uname, unused
jaraco Mar 8, 2019
9a628c4
Restore platform.processor behavior to match prior expectation (relia…
jaraco Mar 8, 2019
3977f63
Extract '_unknown_as_blank' function.
jaraco Mar 8, 2019
acd024e
Override uname_result to resolve the processor late.
jaraco Mar 8, 2019
9aacda9
Add a test intended to capture the expected values from 'uname -p'
jaraco Apr 14, 2019
aa29701
Instead of trying to keep track of all of the possible outputs on dif…
jaraco Apr 14, 2019
01ac684
Use a skipIf directive
jaraco Apr 14, 2019
9df8602
Use contextlib.suppress to suppress the error. Inline strip call.
jaraco Apr 14, 2019
793ddce
Merge branch 'feature/35967-uname-processor-baseline-tests' into feat…
jaraco Apr 14, 2019
ef4662d
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 14, 2019
77dabaf
Merge branch 'master' into feature/35967-platform-processor-resolved-…
jaraco Apr 15, 2020
f0daf49
Merge branch 'master' into feature/35967-platform-processor-resolved-…
jaraco Apr 16, 2020
d57e3ab
Remove use of contextlib.suppress (it would fail with NameError if it…
jaraco Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Lib/test/test_platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import sysconfig
import tempfile
import unittest
import collections
import contextlib
from unittest import mock

from test import support
Expand Down Expand Up @@ -189,6 +191,18 @@ def test_uname(self):
self.assertEqual(res[4], res.machine)
self.assertEqual(res[5], res.processor)

@unittest.skipIf(sys.platform in ['win32', 'OpenVMS'], "uname -p not used")
def test_uname_processor(self):
"""
On some systems, the processor must match the output
of 'uname -p'. See Issue 35967 for rationale.
"""
with contextlib.suppress(subprocess.CalledProcessError):
self.assertEqual(
platform.uname().processor,
subprocess.check_output(['uname', '-p'], text=True).strip(),
)

@unittest.skipUnless(sys.platform.startswith('win'), "windows only test")
def test_uname_win32_ARCHITEW6432(self):
# Issue 7860: make sure we get architecture from the correct variable
Expand Down