Skip to content

gh-117482: Make the Slot Wrapper Inheritance Tests Much More Thorough #122867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 16 commits into from
Aug 12, 2024
Merged

gh-117482: Make the Slot Wrapper Inheritance Tests Much More Thorough #122867

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cdea026
Keep track of the mapping between tp slots and dunder methods.
ericsnowcurrently Aug 7, 2024
c2a7878
get_type_slot_wrapper_names() -> identify_type_slots().
ericsnowcurrently Aug 8, 2024
c51e2a8
Fix iter_builtin_types().
ericsnowcurrently Jul 30, 2024
4007697
Refactor test_static_types_inherited_slots().
ericsnowcurrently Aug 8, 2024
98044a5
Temporarily hide failing corner cases.
ericsnowcurrently Aug 8, 2024
0f71f95
Add a thorough search to test.support.iter_builtin_types().
ericsnowcurrently Aug 8, 2024
bfd2977
Add _PyStaticType_GetBuiltins() and _testinternalcapi.get_static_buil…
ericsnowcurrently Jul 26, 2024
ed318c2
Use the new C-API in test.support.iter_builtin_types().
ericsnowcurrently Jul 30, 2024
2e3a3b8
Clean up usage of _testinternalcapi.
ericsnowcurrently Aug 8, 2024
9bf965a
Add test.support.identify_type_slots().
ericsnowcurrently Aug 8, 2024
86ba359
Add test.support.find_name_in_mro().
ericsnowcurrently Aug 9, 2024
2ebebd3
Use identify_type_slots() and find_name_in_mro() in iter_slot_wrapper…
ericsnowcurrently Aug 9, 2024
9af3eba
Add test.support.identify_type_slot_wrappers().
ericsnowcurrently Aug 9, 2024
0e0e6fd
Don't worry about preserving the slot names.
ericsnowcurrently Aug 9, 2024
83d5c6a
Revert "Clean up usage of _testinternalcapi."
ericsnowcurrently Aug 12, 2024
c1c4ee4
Fix a compiler warning.
ericsnowcurrently Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use identify_type_slots() and find_name_in_mro() in iter_slot_wrapper… 
…s().
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Aug 9, 2024
commit 2ebebd38d6af53533e45842a74abb7bf81cdbfb3
14 changes: 14 additions & 0 deletions Lib/test/support/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2737,6 +2737,20 @@ def is_slot_wrapper(name, value):
assert name.startswith('__') and name.endswith('__'), (cls, name, value)
return True

try:
slots, duplicates = identify_type_slots(reverse=True)
except NotImplementedError:
slots = None
if slots is not None:
for attr in sorted(slots):
obj, base = find_name_in_mro(cls, attr, None)
if obj is not None and is_slot_wrapper(attr, obj):
slot = slots[attr]
yield attr, base is cls
return

# Fall back to a naive best-effort approach.

ns = vars(cls)
unused = set(ns)
for name in dir(cls):
Expand Down