Skip to content

GH-115776: Allow any fixed sized object to have inline values #123192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 9 commits into from
Aug 21, 2024
Merged

GH-115776: Allow any fixed sized object to have inline values #123192

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2c1119d
Allow any fixed object to have inline values
markshannon Aug 20, 2024
a3e6464
Use tp_basicsize
markshannon Aug 20, 2024
89655c9
Use offset, not index in LOAD/STORE_ATTR_INSTANCE_VALUE for speed.
markshannon Aug 21, 2024
f26cf53
Add news
markshannon Aug 21, 2024
7cc8996
Update gdb support
markshannon Aug 21, 2024
2315e0a
Fix up tier 2
markshannon Aug 21, 2024
cb6b30a
Update free-threading version of the GC module
markshannon Aug 21, 2024
ebad934
Update docs on inline values
markshannon Aug 21, 2024
9523760
Update Objects/object_layout.md
markshannon Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use tp_basicsize
  • Loading branch information
@markshannon
markshannon committed Aug 20, 2024
commit a3e64643f8a6cac1790e01459bb96e9b11f4a4a1
1 change: 0 additions & 1 deletion Include/cpython/object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ struct _typeobject {
/* bitset of which type-watchers care about this type */
unsigned char tp_watched;
uint16_t tp_versions_used;
uint16_t tp_inline_values_offset;
};

/* This struct is used by the specializer
Expand Down
4 changes: 2 additions & 2 deletions Include/internal/pycore_object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,10 +804,10 @@ static inline PyDictValues *
_PyObject_InlineValues(PyObject *obj)
{
PyTypeObject *tp = Py_TYPE(obj);
assert(tp->tp_inline_values_offset > 0 && tp->tp_inline_values_offset % sizeof(PyObject *) == 0);
assert(tp->tp_basicsize > 0 && tp->tp_basicsize % sizeof(PyObject *) == 0);
assert(Py_TYPE(obj)->tp_flags & Py_TPFLAGS_INLINE_VALUES);
assert(Py_TYPE(obj)->tp_flags & Py_TPFLAGS_MANAGED_DICT);
return (PyDictValues *)((char *)obj + tp->tp_inline_values_offset);
return (PyDictValues *)((char *)obj + tp->tp_basicsize);
}

extern PyObject ** _PyObject_ComputedDictPointer(PyObject *);
Expand Down
1 change: 0 additions & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8341,7 +8341,6 @@ type_ready_managed_dict(PyTypeObject *type)
}
}
if (type->tp_itemsize == 0) {
type->tp_inline_values_offset = type->tp_basicsize;
type->tp_flags |= Py_TPFLAGS_INLINE_VALUES;
}
return 0;
Expand Down