gh-123504: Fix regression in _tkinter initializer #123662
Merged
vstinner merged 6 commits intopython:mainfrom Sep 4, 2024
Merged
gh-123504: Fix regression in _tkinter initializer #123662vstinner merged 6 commits intopython:mainfrom
_tkinter initializer #123662vstinner merged 6 commits intopython:mainfrom
Conversation
Member
Author
|
(@encukou, this needs |
picnixz
reviewed
Sep 4, 2024
Member
|
You can @ either me or @Eclips4 for skip news requests since we are triagers, or we'll just see whether this is needed or not when we'll look at the PR. |
Member
Author
I would, but Petr specifically requested that I ping him for label changes (he's "mentoring" me for triage membership). |
Member
Author
|
Does that look alright? |
picnixz
approved these changes
Sep 4, 2024
Member
picnixz
left a comment
There was a problem hiding this comment.
Sounds good! If I were to nitpick I would have (in the previous PR that I wasn't able to comment since it was merged before):
Py_UNUSED(module)in themodule_traversesignaturePy_UNUSED(mod)in themodule_clearsignature(void)module_clear((PyObject *)mod);inmodule_free- Renamed the functions to
_tkintermodule_{clear,traverse,free}.
You could do those cosmetic changes if you want but otherwise it's fine.
…/cpython into tkinter-regression
Member
Author
|
I'm going to leave the names as is, we can change them if we decide to migrate tkinter over to PEP 489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @serhiy-storchaka
_tkinterleaks type references on initialization #123504