Skip to content

gh-123275: Add tests for PYTHON_GIL=1 and -Xgil=1#123754

Merged
corona10 merged 1 commit intopython:mainfrom
ZeroIntensity:fix-xgil-1-tests
Sep 6, 2024
Merged

gh-123275: Add tests for PYTHON_GIL=1 and -Xgil=1#123754
corona10 merged 1 commit intopython:mainfrom
ZeroIntensity:fix-xgil-1-tests

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Sep 6, 2024 •
edited by bedevere-app bot
Loading

cc @corona10

Maybe we should merge #123753 and then backport this to 3.13 right after?

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 6, 2024
@corona10
Copy link
Member

corona10 commented Sep 6, 2024

Maybe we should merge #123753 and then backport this to 3.13 right after?

Yeah I will.

@ZeroIntensity
Copy link
Member Author

ZeroIntensity commented Sep 6, 2024

This needs skip news

@corona10 corona10 changed the title gh-123275: Hotfix: add tests for PYTHON_GIL=1 and -Xgil=1 gh-123275: Add tests for PYTHON_GIL=1 and -Xgil=1 Sep 6, 2024
@corona10 corona10 self-assigned this Sep 6, 2024
corona10
corona10 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 enabled auto-merge (squash) September 6, 2024 00:58
@corona10 corona10 added the needs backport to 3.13 bugs and security fixes label Sep 6, 2024
@corona10 corona10 merged commit fe24b71 into python:main Sep 6, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 6, 2024

Thanks @ZeroIntensity for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2024
@ZeroIntensity @miss-islington
pythongh-123275: Add tests for PYTHON_GIL=1 and -Xgil=1 (pythongh…
2fc329a 
…-123754)

(cherry picked from commit fe24b71)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 6, 2024

GH-123755 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 6, 2024
@ZeroIntensity ZeroIntensity deleted the fix-xgil-1-tests branch September 6, 2024 01:16
corona10 pushed a commit that referenced this pull request Sep 6, 2024
@miss-islington @ZeroIntensity
[3.13] gh-123275: Add tests for PYTHON_GIL=1 and -Xgil=1 (gh-123754…
fb50266 
…) (gh-123755)

gh-123275: Add tests for `PYTHON_GIL=1` and `-Xgil=1` (gh-123754)
(cherry picked from commit fe24b71)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Assignees

@corona10 corona10

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity @corona10