gh-119726: generate and patch AArch64 trampolines#123872
Merged
brandtbucher merged 15 commits intopython:mainfrom Oct 2, 2024
Merged
gh-119726: generate and patch AArch64 trampolines#123872brandtbucher merged 15 commits intopython:mainfrom
brandtbucher merged 15 commits intopython:mainfrom
Conversation
5 tasks
a7a04fc to
8cbca05
Compare
Member
brandtbucher
left a comment
There was a problem hiding this comment.
This is great! I'd like to see this mechanism used across all platforms for symbols in the "global offset table" too (but that can be a separate project).
It's a clear improvement for the affected platforms:
aarch64-unknown-linux-gnu: 0.8% faster, 0.6% less memory.aarch64-apple-darwin: 1.5% faster, 0.8% less memory.
Here's an initial review of the Python code. I'll dig into the C code tomorrow.
Contributor
Author
Well better than nothing :) |
7bdf9f0 to
ffd74bd
Compare
f523e6a to
43c6f98
Compare
Member
brandtbucher
left a comment
There was a problem hiding this comment.
Thanks for your patience! This is looking really good.
A few thoughts I had reading the C code:
94a2c1e to
bf3b14f
Compare
AArch64 trampolines are now generated at runtime at the end of every trace.
ca75436 to
6723f87
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AArch64 trampolines are now generated at runtime at the end of every trace.