Skip to content

gh-123940: Ensure force-terminated daemon threads can be joined #124150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpage wants to merge 16 commits into from
Closed

gh-123940: Ensure force-terminated daemon threads can be joined #124150

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
04c6803
gh-123940: Ensure force-terminated daemon threads can be joined
mpage Sep 16, 2024
679ce7d
Add suppression for _PyThreadState_MustExit
mpage Sep 17, 2024
4d02a0b
Merge branch 'main' into gh-123940
mpage Sep 17, 2024
cd7b7d1
Remove incorrect warnignore line
mpage Sep 17, 2024
bf186e2
Assert that finalizer is called
mpage Sep 17, 2024
96613ed
Note the test that triggers the race in _PyThreadState_MustExit
mpage Sep 17, 2024
d18c872
Merge branch 'main' into gh-123940
mpage Sep 17, 2024
33ab654
Revert changes
mpage Sep 17, 2024
192b260
Mark all daemon threads as done during finalization
mpage Sep 18, 2024
57a1c65
Merge branch 'main' into gh-123940
mpage Sep 18, 2024
aa1039a
Only notify, don't mark handles as done
mpage Sep 18, 2024
3978cc0
Document contract between wait_for_thread_shutdown and daemon_threads…
mpage Sep 18, 2024
5991fa4
Don't pass threading module between wait_for_thread_shutdown and daem…
mpage Sep 18, 2024
9a94905
Don't call into Python to mark daemon threads completed
mpage Sep 18, 2024
512b5fc
Regen global objects
mpage Sep 18, 2024
70f28c8
Maybe fix windows build
mpage Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into gh-123940
  • Loading branch information
@mpage
mpage committed Sep 17, 2024
commit d18c872286e28e97963426c64e0d7046afa1c0ce

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.