Skip to content

gh-123884 Tee of tee was not producing n independent iterators #124490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 9 commits into from
Sep 25, 2024
Merged

gh-123884 Tee of tee was not producing n independent iterators #124490

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6ce5cb0
Working fix
rhettinger Sep 24, 2024
2a7a4d3
Clean-up unused path
rhettinger Sep 24, 2024
e397bfd
Update tee() rough equivalent recipe and related tests
rhettinger Sep 25, 2024
8e2315c
Add blurb
rhettinger Sep 25, 2024
4e4fad4
Call tee_copy() directly
rhettinger Sep 25, 2024
1a56697
Merge branch 'main' into tee1
rhettinger Sep 25, 2024
ee064e7
Beautify the pure python version
rhettinger Sep 25, 2024
f2f0a6e
Merge branch 'main' into tee1
rhettinger Sep 25, 2024
6153e70
Remove unused __copy__ constant
rhettinger Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean-up unused path
  • Loading branch information
@rhettinger
rhettinger committed Sep 24, 2024
commit 2a7a4d32ef4a93e9a7021b81600e25c5c5c33246
28 changes: 9 additions & 19 deletions Modules/itertoolsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,28 +1053,18 @@ itertools_tee_impl(PyObject *module, PyObject *iterable, Py_ssize_t n)
return NULL;
}

if (PyObject_GetOptionalAttr(it, &_Py_ID(__copy__), &copyfunc) < 0) {
Py_DECREF(it);
itertools_state *state = get_module_state(module);
copyable = tee_fromiterable(state, it);
Py_DECREF(it);
if (copyable == NULL) {
Py_DECREF(result);
return NULL;
}
if (copyfunc != NULL && 0) {
copyable = it;
}
else {
itertools_state *state = get_module_state(module);
copyable = tee_fromiterable(state, it);
Py_DECREF(it);
if (copyable == NULL) {
Py_DECREF(result);
return NULL;
}
copyfunc = PyObject_GetAttr(copyable, &_Py_ID(__copy__));
if (copyfunc == NULL) {
Py_DECREF(copyable);
Py_DECREF(result);
return NULL;
}
copyfunc = PyObject_GetAttr(copyable, &_Py_ID(__copy__));
if (copyfunc == NULL) {
Py_DECREF(copyable);
Py_DECREF(result);
return NULL;
}

PyTuple_SET_ITEM(result, 0, copyable);
Expand Down