Skip to content

gh-124442: make __static_attributes__ deterministic by sorting #124492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 6 commits into from
Sep 28, 2024
Merged

gh-124442: make __static_attributes__ deterministic by sorting #124492

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e097874
fix issue #124442: make `__static_attributes__` deterministic by sorting
kp2pml30 Sep 25, 2024
676ddad
fail if sort fails, add a test
kp2pml30 Sep 25, 2024
17d8e4c
patch docs
kp2pml30 Sep 27, 2024
c026422
Rewrite test and NEWS entry
JelleZijlstra Sep 28, 2024
b1e6bd5
Merge remote-tracking branch 'upstream/main' into fix-issue-124442
JelleZijlstra Sep 28, 2024
bb93cca
Update Lib/test/test_compile.py
JelleZijlstra Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
patch docs 
Signed-off-by: kp2pml30 <kp2pml30@gmail.com>
  • Loading branch information
@kp2pml30
kp2pml30 committed Sep 27, 2024
commit 17d8e4c07ebaa859900c3e510b5c0141424a32e7
3 changes: 1 addition & 2 deletions Misc/NEWS.d/next/Core_and_Builtins/2024-09-25-11-53-22.gh-issue-124442.EXC1Ve.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
Make the :func:`compile` builtin function deterministic by sorting
:attr:`~class.__static_attributes__` before writing to bytecode.
Fix nondeterminism in compilation of ``__static_attributes__`` by sorting