Skip to content

gh-124928: Emscripten node support: Clean up old node <= 16 flags #124929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 4 commits into from
Oct 29, 2024
Merged

gh-124928: Emscripten node support: Clean up old node <= 16 flags #124929

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f90c237
Emscripten: Clean up flags for old node versions
hoodmane Oct 3, 2024
ad3c485
Add version check for node < 18
hoodmane Oct 3, 2024
96e9e40
Add blurb
hoodmane Oct 4, 2024
a23986f
Merge branch 'main' into emscripten-node-flag-cleanup
freakboy3742 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Emscripten: Clean up flags for old node versions 
These flags are only needed for node <= 16. Node 16 has been end of life since
October of 2023.
  • Loading branch information
@hoodmane
hoodmane committed Oct 3, 2024
commit f90c2370ccd682562475c651031337b6a9d3a90c
55 changes: 0 additions & 55 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 0 additions & 28 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,34 +1619,6 @@ then
[Emscripten/node*], [
AC_PATH_TOOL([NODE], [node], [node])
HOSTRUNNER="$NODE"
# bigint for ctypes c_longlong, c_longdouble
# no longer available in Node 16
AC_CACHE_CHECK([for node --experimental-wasm-bigint], [ac_cv_tool_node_wasm_bigint], [
if $NODE -v --experimental-wasm-bigint > /dev/null 2>&1; then
ac_cv_tool_node_wasm_bigint=yes
else
ac_cv_tool_node_wasm_bigint=no
fi
])
AS_VAR_IF([ac_cv_tool_node_wasm_bigint], [yes], [
AS_VAR_APPEND([HOSTRUNNER], [" --experimental-wasm-bigint"])
])

AS_VAR_IF([enable_wasm_pthreads], [yes], [
AS_VAR_APPEND([HOSTRUNNER], [" --experimental-wasm-threads"])
# no longer available in Node 16
AC_CACHE_CHECK([for node --experimental-wasm-bulk-memory], [ac_cv_tool_node_wasm_bulk_memory], [
if $NODE -v --experimental-wasm-bulk-memory > /dev/null 2>&1; then
ac_cv_tool_node_wasm_bulk_memory=yes
else
ac_cv_tool_node_wasm_bulk_memory=no
fi
])
AS_VAR_IF([ac_cv_tool_node_wasm_bulk_memory], [yes], [
AS_VAR_APPEND([HOSTRUNNER], [" --experimental-wasm-bulk-memory"])
])
])

AS_VAR_IF([host_cpu], [wasm64], [AS_VAR_APPEND([HOSTRUNNER], [" --experimental-wasm-memory64"])])
],
dnl TODO: support other WASI runtimes
Expand Down