Skip to content

GH-123599: url2pathname(): handle authority section in file URL #126844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 26 commits into from
Apr 10, 2025
Merged

GH-123599: url2pathname(): handle authority section in file URL #126844

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
50231c5
GH-126838: `url2pathname()`: handle non-empty authority section on POSIX
barneygale Nov 14, 2024
9032105
Fix test
barneygale Nov 14, 2024
b91afca
Undo unnecessary change
barneygale Nov 14, 2024
4b320b8
Fix Windows tests
barneygale Nov 14, 2024
0cc3a67
More test fixes
barneygale Nov 14, 2024
96fdb01
Merge branch 'main' into gh-126838
barneygale Nov 19, 2024
52010ca
Merge branch 'main' into gh-126838
barneygale Nov 19, 2024
f64ca0d
Merge branch 'main' into gh-126838
barneygale Mar 19, 2025
ab800ab
Updatez
barneygale Mar 19, 2025
40d346a
Fix tests #1
barneygale Mar 19, 2025
69807b4
Merge branch 'main' into gh-126838
barneygale Mar 19, 2025
79f5d05
Restore previous Windows behaviour
barneygale Mar 19, 2025
bb69e49
Fix WASI, docs
barneygale Mar 19, 2025
7adddbf
wasi yousa problem?
barneygale Mar 19, 2025
b4fa510
Merge branch 'main' into gh-126838
barneygale Mar 20, 2025
b5e5460
Update whatsnew
barneygale Mar 20, 2025
67fccd5
Apply suggestions from code review
barneygale Mar 20, 2025
89ddf7f
Address some review feedback
barneygale Mar 20, 2025
d327f34
Apply suggestions from code review
barneygale Mar 29, 2025
313a68f
Swap .. versionchanged:: order
barneygale Mar 29, 2025
e1f6d10
Add test cases involving ports
barneygale Mar 29, 2025
c5f5e24
Add test methods for common posix/windows results
barneygale Mar 29, 2025
25521c1
Windows test fixes
barneygale Mar 29, 2025
fa77456
Restore FileHandler.names and get_names()
barneygale Mar 29, 2025
3a50641
Docs improvements
barneygale Apr 10, 2025
eecff9b
Merge branch 'main' into gh-126838
barneygale Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More test fixes
  • Loading branch information
@barneygale
barneygale committed Nov 14, 2024
commit 0cc3a673fe7776630a8ccd6951a2085dd0f51137
2 changes: 1 addition & 1 deletion Lib/test/test_urllib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ def test_missing_localfile(self):

def test_file_notexists(self):
fd, tmp_file = tempfile.mkstemp()
tmp_fileurl = 'file://localhost' + tmp_file.replace(os.path.sep, '/')
tmp_fileurl = 'file:' + urllib.request.pathname2url(tmp_file)
try:
self.assertTrue(os.path.exists(tmp_file))
with urlopen(tmp_fileurl) as fobj:
Expand Down