Skip to content

gh-126914: Store the Preallocated Thread State's Pointer in a PyInterpreterState Field #126989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 9 commits into from
Nov 19, 2024
Merged

gh-126914: Store the Preallocated Thread State's Pointer in a PyInterpreterState Field #126989

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c6ca28
Move the location of a PyInterpreterState field.
ericsnowcurrently Nov 18, 2024
e0d363c
Add a test.
ericsnowcurrently Nov 18, 2024
bbd4ae6
Always reset the initial tstate when re-used.
ericsnowcurrently Nov 18, 2024
e627718
Add a thread state freelist.
ericsnowcurrently Nov 18, 2024
7cdc4cf
Fix a typo.
ericsnowcurrently Nov 19, 2024
d8fc3c5
Add a NULL check.
ericsnowcurrently Nov 19, 2024
243e444
Apply a testing decorator.
ericsnowcurrently Nov 19, 2024
4f815c6
Retry if already running in the test.
ericsnowcurrently Nov 19, 2024
fcbe56d
freelist -> preallocated
ericsnowcurrently Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Retry if already running in the test.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Nov 19, 2024
commit 4f815c65ebb1f9a01ebb630ed833ffe88836aa23
13 changes: 12 additions & 1 deletion Lib/test/test_interpreters/test_stress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,18 @@ def test_many_threads_running_interp_in_other_interp(self):

def run():
interp = interpreters.create()
interp.exec(script)
alreadyrunning = (f'{interpreters.InterpreterError}: '
'interpreter already running')
success = False
while not success:
try:
interp.exec(script)
except interpreters.ExecutionFailed as exc:
if exc.excinfo.msg != 'interpreter already running':
raise # re-raise
assert exc.excinfo.type.__name__ == 'InterpreterError'
else:
success = True

threads = (threading.Thread(target=run) for _ in range(200))
with threading_helper.start_threads(threads):
Expand Down