gh-127303: Add docs for token.EXACT_TOKEN_TYPES by lubaskinc0de · Pull Request #127304 · python/cpython

lubaskinc0de · 2024-11-26T20:06:58Z

Issue: Document token.EXACT_TOKEN_TYPES #127303

📚 Documentation preview 📚: https://cpython-previews--127304.org.readthedocs.build/

ghost · 2024-11-26T20:07:01Z

All commit authors signed the Contributor License Agreement.

Eclips4

LGTM. Ilya and I checked that it was added in version 3.8. Although I'm a bit unsure about the wording, I think it could be improved, but neither I nor Ilya are native English speakers :(

Doc/library/token.rst

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>

terryjreedy

Now that it is documented, EXACT_TOKEN_TYPES needs to be added to __all__ at the top of token.py. In particular, line 4, which should then be wrapped to 2 lines.

__all__ = ['tok_name', 'ISTERMINAL', 'ISNONTERMINAL', 'ISEOF',
           'EXACT_TOKEN_TYPES']

EDIT: The complication is that token.py is auto-generated by Tools/build/generate_token.py, so it is the latter that needs revision. In particular, expand line 229 of that file to 2 lines.

bedevere-app · 2024-11-26T22:23:01Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

lubaskinc0de · 2024-11-27T13:14:41Z

I have made the requested changes; please review again

bedevere-app · 2024-11-27T13:14:47Z

Thanks for making the requested changes!

@terryjreedy, @Eclips4: please review the changes made to this pull request.

picnixz

While the attribute already existed its scope was not specifically public. Now we can really stress that it's public and documented.

picnixz · 2024-11-27T14:18:43Z

Doc/library/token.rst

+   A dictionary mapping the string representation of a token to its numeric code.
+
+   .. versionadded:: 3.8
+


Can we have two blank lines here? (as above)

Misc/ACKS

Misc/NEWS.d/next/Library/2024-11-27-16-06-10.gh-issue-127303.asqkgh.rst

…sqkgh.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Eclips4

LGTM.

miss-islington-app · 2024-11-29T09:00:54Z

Thanks @lubaskinc0de for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

--------- (cherry picked from commit dd3a87d) Co-authored-by: Илья Любавский <100635212+lubaskinc0de@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tomas R. <tomas.roun8@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app · 2024-11-29T09:01:22Z

GH-127390 is a backport of this pull request to the 3.13 branch.

--------- (cherry picked from commit dd3a87d) Co-authored-by: Илья Любавский <100635212+lubaskinc0de@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tomas R. <tomas.roun8@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app · 2024-11-29T09:01:28Z

GH-127391 is a backport of this pull request to the 3.12 branch.

…127391) gh-127303: Add docs for token.EXACT_TOKEN_TYPES (GH-127304) --------- (cherry picked from commit dd3a87d) Co-authored-by: Илья Любавский <100635212+lubaskinc0de@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tomas R. <tomas.roun8@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…127390) gh-127303: Add docs for token.EXACT_TOKEN_TYPES (GH-127304) --------- (cherry picked from commit dd3a87d) Co-authored-by: Илья Любавский <100635212+lubaskinc0de@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tomas R. <tomas.roun8@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-bot · 2024-11-30T08:56:39Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel NoGIL 3.13 has failed when building commit 4cba0e6.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1449/builds/718) and take a look at the build logs.
Check if the failure is related to this commit (4cba0e6) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1449/builds/718

Failed tests:

test_threading

Failed subtests:

test_start_new_thread_failed - test.test_threading.ThreadTests.test_start_new_thread_failed

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-intel-aws.nogil/build/Lib/test/test_threading.py", line 1205, in test_start_new_thread_failed
    self.assertEqual(out, b'ok')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: b"skip\nshouldn't be printed" != b'ok'

--------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tomas R. <tomas.roun8@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Add docs for token.EXACT_TOKEN_TYPES

dcba1b8

bedevere-app bot added docs Documentation in the Doc dir skip news labels Nov 26, 2024

bedevere-app bot mentioned this pull request Nov 26, 2024

Document token.EXACT_TOKEN_TYPES #127303

Closed

bedevere-app bot added the awaiting review label Nov 26, 2024

Eclips4 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 26, 2024

lubaskinc0de added 2 commits November 26, 2024 23:14

first contribution

931b175

fix bold text

1ddb3f9

Eclips4 approved these changes Nov 26, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Nov 26, 2024

tomasr8 reviewed Nov 26, 2024

View reviewed changes

Doc/library/token.rst Outdated Show resolved Hide resolved

Update Doc/library/token.rst

7e19d69

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>

terryjreedy requested changes Nov 26, 2024

View reviewed changes

bedevere-app bot removed the awaiting merge label Nov 26, 2024

bedevere-app bot added the awaiting changes label Nov 26, 2024

lubaskinc0de added 2 commits November 27, 2024 16:12

add to __all__ and split

1c7c39b

Merge remote-tracking branch 'fork/issue/127303' into issue/127303

5d0dada

bedevere-app bot added awaiting change review and removed awaiting changes labels Nov 27, 2024

bedevere-app bot requested review from Eclips4 and terryjreedy November 27, 2024 13:14

picnixz reviewed Nov 27, 2024

View reviewed changes

lubaskinc0de and others added 2 commits November 27, 2024 18:18

Update Misc/NEWS.d/next/Library/2024-11-27-16-06-10.gh-issue-127303.a…

6f131ac

…sqkgh.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

address review

723e057

Merge remote-tracking branch 'fork/issue/127303' into issue/127303

4dcfade

lubaskinc0de requested a review from picnixz November 27, 2024 15:23

Eclips4 approved these changes Nov 28, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting change review labels Nov 28, 2024

terryjreedy approved these changes Nov 29, 2024

View reviewed changes

terryjreedy merged commit dd3a87d into python:main Nov 29, 2024

bedevere-app bot removed the awaiting merge label Nov 29, 2024

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 29, 2024

bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 29, 2024

lubaskinc0de deleted the issue/127303 branch November 29, 2024 10:47

Eclips4 mentioned this pull request Nov 30, 2024

gh-127347: Document traceback.print_list #127348

Merged

		A dictionary mapping the string representation of a token to its numeric code.

		.. versionadded:: 3.8

Uh oh!

Conversation

lubaskinc0de commented Nov 26, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Nov 26, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eclips4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

terryjreedy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bedevere-app bot commented Nov 26, 2024

Uh oh!

lubaskinc0de commented Nov 27, 2024

Uh oh!

bedevere-app bot commented Nov 27, 2024

Uh oh!

picnixz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

picnixz Nov 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Eclips4 left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app bot commented Nov 29, 2024

Uh oh!

bedevere-app bot commented Nov 29, 2024

Uh oh!

bedevere-app bot commented Nov 29, 2024

Uh oh!

bedevere-bot commented Nov 30, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lubaskinc0de commented Nov 26, 2024 •

edited by github-actions bot

Loading

ghost commented Nov 26, 2024 •

edited by ghost

Loading

terryjreedy left a comment •

edited

Loading

picnixz left a comment •

edited

Loading