Skip to content

GH-128520: pathlib ABCs: reject empty pattern in ReadablePath.glob() #127343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 2 commits into from
Mar 24, 2025
+4 −0
Merged

GH-128520: pathlib ABCs: reject empty pattern in ReadablePath.glob() #127343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7551c11
pathlib ABCs: reject empty pattern in `glob()`
barneygale Nov 27, 2024
b481eef
Merge branch 'main' into pathlib-abc-glob-empty-pattern
barneygale Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
pathlib ABCs: reject empty pattern in glob() 
For compatibility with `Path.glob()`, raise `ValueError` if an empty
pattern is given to `PathBase.glob()`.
  • Loading branch information
@barneygale
barneygale committed Nov 27, 2024
commit 7551c1108ae1e5d9498ee70f8e02a2a6d0b26226
2 changes: 2 additions & 0 deletions Lib/pathlib/_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,8 @@ def glob(self, pattern, *, case_sensitive=None, recurse_symlinks=True):
anchor, parts = pattern._stack
if anchor:
raise NotImplementedError("Non-relative patterns are unsupported")
elif not parts:
raise ValueError(f"Unacceptable pattern: {pattern!r}")
select = self._glob_selector(parts, case_sensitive, recurse_symlinks)
return select(self)

Expand Down
3 changes: 2 additions & 1 deletion Lib/test/test_pathlib/test_pathlib_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2284,7 +2284,8 @@ def test_glob_windows(self):
def test_glob_empty_pattern(self):
P = self.cls
p = P(self.base)
self.assertEqual(list(p.glob("")), [p])
with self.assertRaisesRegex(ValueError, 'Unacceptable pattern'):
list(p.glob(""))
self.assertEqual(list(p.glob(".")), [p / "."])
self.assertEqual(list(p.glob("./")), [p / "./"])

Expand Down