[3.12] Link to correct class methods in asyncio primitives docs (GH-127270)#127438
Merged
kumaraditya303 merged 2 commits intopython:3.12from Nov 30, 2024
Merged
Conversation
Contributor
Can you just fix the links and not add this para? That change dates back to #112201 which isn't present in 3.12 AFAIK. |
This removes the irrelevant note for 3.12.
Member
Author
|
Done. I can also remove the paragraph "The method will repeatedly :meth:`~Condition.wait` until the predicate evaluates to *true*." if you think we shouldn't improve the 3.12 docs with this note. |
kumaraditya303
approved these changes
Nov 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 15d6506)
Co-authored-by: Ollanta Cuba Gyllensten ollantaster@gmail.com
@kumaraditya303
I've checked that
wait_fordoes indeed callwait()before checking the predicate but I'd like to know whether this additional paragraph forwaitis needed or not:Note
Note that a task may return from this call spuriously,
which is why the caller should always re-check the state
and be prepared to :meth:
~Condition.waitagain. For this reason, you mayprefer to use :meth:
~Condition.wait_forinstead.📚 Documentation preview 📚: https://cpython-previews--127438.org.readthedocs.build/