Skip to content

gh-127353: Allow to force color output on Windows V2#127926

Merged
hugovk merged 2 commits intopython:mainfrom
PalmtopTiger:gh-127353
Dec 14, 2024
Merged

gh-127353: Allow to force color output on Windows V2#127926
hugovk merged 2 commits intopython:mainfrom
PalmtopTiger:gh-127353

Conversation

@PalmtopTiger
Copy link
Contributor

@PalmtopTiger PalmtopTiger commented Dec 13, 2024 •
edited by bedevere-app bot
Loading

This PR allows to force color output on Windows and brings the behavior of can_colorize function into compliance with POSIX. Second version of #127354 with fixed tests.

@bedevere-app bedevere-app bot mentioned this pull request Dec 13, 2024
Closed
@PalmtopTiger
Copy link
Contributor Author

PalmtopTiger commented Dec 13, 2024

@hugovk, could you check this PR please?

@ZeroIntensity ZeroIntensity added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 13, 2024
@bedevere-bot
Copy link

bedevere-bot commented Dec 13, 2024

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit a50e877 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 13, 2024
hugovk
hugovk reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good so far!

The two current buildbot failures are unrelated and also happen elsewhere, and there might be a third unrelated to come, but all the other buildbots are now passing. 👍

@hugovk hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 14, 2024
@bedevere-bot
Copy link

bedevere-bot commented Dec 14, 2024

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 6946167 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 14, 2024
hugovk
hugovk approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This is now passing on all the buildbots, except for two which are unrelated (it's #125588 (comment)).

@hugovk hugovk added the needs backport to 3.13 bugs and security fixes label Dec 14, 2024
@hugovk hugovk merged commit 0ac40ac into python:main Dec 14, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 14, 2024

Thanks @PalmtopTiger for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 14, 2024
@PalmtopTiger @miss-islington
pythongh-127353: Allow to force color output on Windows V2 (pythonGH-…
e9af85a 
…127926)

(cherry picked from commit 0ac40ac)

Co-authored-by: Andrey Efremov <duxus@yandex.ru>
@bedevere-app
Copy link

bedevere-app bot commented Dec 14, 2024

GH-127944 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 14, 2024
@ZeroIntensity
Copy link
Member

ZeroIntensity commented Dec 14, 2024

Let's hope this doesn't break anything else!

@hugovk
Copy link
Member

hugovk commented Dec 14, 2024

Yeah, will wait until tomorrow before merging the backport :)

hugovk pushed a commit that referenced this pull request Dec 15, 2024
@miss-islington @PalmtopTiger
[3.13] gh-127353: Allow to force color output on Windows V2 (GH-127926)…
90ae4b6 
… (#127944)

gh-127353: Allow to force color output on Windows V2 (GH-127926)
(cherry picked from commit 0ac40ac)

Co-authored-by: Andrey Efremov <duxus@yandex.ru>
@PalmtopTiger PalmtopTiger deleted the gh-127353 branch December 16, 2024 06:18
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@PalmtopTiger @srinivasreddy
pythongh-127353: Allow to force color output on Windows V2 (python#12…
bf38a18 
…7926)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PalmtopTiger @bedevere-bot @ZeroIntensity @hugovk