Skip to content

gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings #128726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 21 commits into from
Jan 17, 2025
Merged

gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings #128726

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0d28ddd
gh-110012: Fix `RuntimeWarning` in `test_socket`
sobolevn Sep 28, 2023
da358cc
Typos!
sobolevn Sep 28, 2023
cf0cfd0
Typos!
sobolevn Sep 28, 2023
dfda254
Use `quiet=True` by default
sobolevn Sep 28, 2023
ec6a368
fix warnings in test_importlib.test_abc
graingert Jan 16, 2025
a5c2b7a
fix warnings found in test_importlib.test_windows
graingert Jan 16, 2025
0f2afcd
set warnings as errors everywhere
graingert Jan 11, 2025
8e97f04
Merge branch 'main' into issue110012
graingert Jan 16, 2025
4982ba4
Merge branch 'issue110012' into run-test-suite-with-warnings-as-error
graingert Jan 16, 2025
f45b3b8
Update test_socket.py
graingert Jan 16, 2025
0bc4c2a
Merge branch 'issue110012' into run-test-suite-with-warnings-as-error
graingert Jan 16, 2025
ca5eb67
fix ResourceWarning in test_pyrepl
graingert Jan 16, 2025
a13e948
Merge branch 'fix-resource-warning-in-test-pyrepl' into run-test-suit…
graingert Jan 16, 2025
7b2b437
downgrade rather than ignore malformed socket warning
graingert Jan 16, 2025
f2cb9b4
Merge branch 'main' into run-test-suite-with-warnings-as-error
graingert Jan 16, 2025
32cd095
Update Lib/test/test_socket.py
graingert Jan 16, 2025
db0cb51
Update Lib/test/test_socket.py
graingert Jan 16, 2025
61eb61f
Update Lib/test/test_socket.py
graingert Jan 16, 2025
91ee5ee
oops, it's not pytest
graingert Jan 16, 2025
720cca0
Merge branch 'main' into run-test-suite-with-warnings-as-error
brettcannon Jan 16, 2025
23469c3
Merge branch 'main' into run-test-suite-with-warnings-as-error
graingert Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Typos!
  • Loading branch information
@sobolevn
sobolevn committed Sep 28, 2023
commit da358cc5d2a78715bc21563ef4487fc336ad8ae9
8 changes: 4 additions & 4 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def socket_setdefaulttimeout(timeout):


@contextlib.contextmanager
def catch_mailformed_data_warning(quite=False):
def catch_malformed_data_warning(quite=False):
with warnings_helper.check_warnings(
("received malformed or improperly-truncated ancillary data", RuntimeWarning),
quite=quite,
Expand Down Expand Up @@ -3884,7 +3884,7 @@ def checkTruncatedArray(self, ancbuf, maxdata, mindata=0):
# mindata and maxdata bytes when received with buffer size
# ancbuf, and that any complete file descriptor numbers are
# valid.
with catch_mailformed_data_warning():
with catch_malformed_data_warning():
msg, ancdata, flags, addr = self.doRecvmsg(self.serv_sock,
len(MSG), ancbuf)
self.assertEqual(msg, MSG)
Expand Down Expand Up @@ -4228,7 +4228,7 @@ def testSingleCmsgTruncInData(self):
self.serv_sock.setsockopt(socket.IPPROTO_IPV6,
socket.IPV6_RECVHOPLIMIT, 1)
self.misc_event.set()
with catch_mailformed_data_warning():
with catch_malformed_data_warning():
msg, ancdata, flags, addr = self.doRecvmsg(
self.serv_sock, len(MSG), socket.CMSG_LEN(SIZEOF_INT) - 1)

Expand Down Expand Up @@ -4333,7 +4333,7 @@ def testSecondCmsgTruncInData(self):
self.serv_sock.setsockopt(socket.IPPROTO_IPV6,
socket.IPV6_RECVTCLASS, 1)
self.misc_event.set()
with catch_mailformed_data_warning():
with catch_malformed_data_warning():
msg, ancdata, flags, addr = self.doRecvmsg(
self.serv_sock, len(MSG),
socket.CMSG_SPACE(SIZEOF_INT) + socket.CMSG_LEN(SIZEOF_INT) - 1)
Expand Down