Skip to content

gh-132502: Implements PEP-829 adding timestamps to tracebacks #129337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gpshead wants to merge 77 commits into
base: main
Choose a base branch
from
Draft

gh-132502: Implements PEP-829 adding timestamps to tracebacks #129337

Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
c5a9ccd
Proof of concept: Add timestamps to tracebacks.
gpshead Jan 27, 2025
3dc00c2
`PYTHON_TRACEBACK_TIMESTAMPS=1` required to enable their display.
gpshead Jan 27, 2025
a05766f
skip timestamp on StopIteration - not an error
gpshead Jan 28, 2025
cdb67f0
include the timestamp in exception pickles.
gpshead Jan 28, 2025
99ffc8a
os.environ not os.environb
gpshead Jan 30, 2025
c119a02
Cleaner struct layout.
gpshead Feb 2, 2025
bcc720b
Timestamp format configurability.
gpshead Feb 2, 2025
b065394
Plumb into exception subtypes; including pickling.
gpshead Feb 2, 2025
09a547a
minor cleanups
gpshead Feb 2, 2025
daa752d
initial pass at documentation.
gpshead Feb 2, 2025
e7fab86
Fix doc references?
gpshead Feb 2, 2025
e8a6297
proper refcount cleanup in error cases.
gpshead Feb 2, 2025
6809426
Merge branch 'main' into traceback-timestamps
gpshead Feb 9, 2025
0d83447
Allow `PyErr_Display*` to emit timestamps as well.
gpshead Feb 10, 2025
7c83ebf
Make the testsuite pass with timestamps turned on.
gpshead Feb 10, 2025
beadfb8
Docs docs docs docs docs
gpshead Feb 10, 2025
354c5f0
docs make check
gpshead Feb 10, 2025
33d20dd
docs typo
gpshead Feb 10, 2025
2f72323
GIT
gpshead Feb 10, 2025
7f7357d
docs: reword exceptions
gpshead Feb 10, 2025
d9d2b1f
vi PEBKAC reformatted traceback.rst? undo
gpshead Feb 10, 2025
98b4593
more formatting messup undo
gpshead Feb 10, 2025
c9ad56d
more undo
gpshead Feb 10, 2025
53b5500
reword some docs, add examples
gpshead Feb 10, 2025
8043b80
REDO BEFORE MERGE: enable on some CI builds
gpshead Feb 10, 2025
75072cb
Go full on -X traceback_timestamps command line flag.
gpshead Feb 26, 2025
eebec1d
Disable time collection when display is disabled.
gpshead Mar 2, 2025
9ff3234
remove errant Doc temp db file
gpshead Mar 2, 2025
f30c74d
WIP: optional config string
gpshead Mar 7, 2025
85496cf
WIP: no dict key for reduce when 0
gpshead Mar 7, 2025
9c8eda4
Merge branch 'main' into traceback-timestamps
gpshead Apr 13, 2025
6949cba
simplify `iso` format to not use datetime
gpshead Apr 14, 2025
b564e63
minor cleanups
gpshead Apr 14, 2025
e6199e3
post merge fixups
gpshead Apr 14, 2025
4c031a6
fix stripping tests
gpshead Apr 14, 2025
23e2538
test fixing when timestamps enabled
gpshead Apr 14, 2025
98ae94f
lets run CI on more platforms with it enabled
gpshead Apr 14, 2025
7d45424
duh why did my compiler allow that?
gpshead Apr 14, 2025
dde0f39
fix windows errors?
gpshead Apr 14, 2025
5f7b930
force_not_colorized
gpshead Apr 14, 2025
964bdd3
force utf8 for the entire test class
gpshead Apr 14, 2025
5554b67
waste time dealing with bad unicode test env. life
gpshead Apr 14, 2025
0f9bb1b
alignment SCIENCE
gpshead Apr 14, 2025
a55c3b1
errors="ignore" chicanery decode
gpshead Apr 14, 2025
d2d7583
Fix traceback_timestamps tests for cross-platform line endings
gpshead Apr 14, 2025
84989bb
(╯°□°)╯︵ ┻━┻ Windows
gpshead Apr 14, 2025
b268c82
pedantic-NotIn-too
gpshead Apr 14, 2025
d0f95ba
Merge origin/main into traceback-timestamps
gpshead May 24, 2025
52a1e25
Fix failing tests when traceback timestamps are enabled
gpshead May 24, 2025
05d6f13
Add comprehensive tests for traceback timestamps feature
gpshead May 24, 2025
1fc9c88
Reduce duplication in traceback timestamps tests
gpshead May 24, 2025
4aaa4dc
ruff format the tests
gpshead May 24, 2025
ec22c19
Optimize exception pickle sizes when timestamps are disabled
gpshead May 24, 2025
1b83faf
TESTSUBDIRS += our new dir for test_tools
gpshead May 24, 2025
1ba3ed4
shakes fist at trailing spaces from claude
gpshead May 25, 2025
1efbc2a
Merge branch 'main' into traceback-timestamps
gpshead Jun 8, 2025
bab3575
pre-commit import fixes
gpshead Jun 8, 2025
77ffb5a
Complete traceback timestamps test coverage gaps
gpshead Jun 8, 2025
a0656ce
📝 Address PR code review comments for documentation and formatting
gpshead Jun 8, 2025
e4f54d4
Remove redundant no_color() context manager
gpshead Jun 8, 2025
ad6bef8
Merge branch 'main' into traceback-timestamps
gpshead Mar 15, 2026
0d5723d
undo errant increase in sys.flags tuple fields from the lazy_imports …
gpshead Mar 15, 2026
d9f6500
ubuntu 24.04 not 22.04
gpshead Mar 15, 2026
a0d6603
docs: address review comments
gpshead Mar 15, 2026
7d2a4d3
adjust test for sys.flags to match limit
gpshead Mar 15, 2026
d617d83
strip timestamps in a new test_repl test
gpshead Mar 15, 2026
cbd5c4c
Add PYTHON_TRACEBACK_TIMESTAMPS to --help-env output
gpshead Mar 15, 2026
3813d9e
NEWS entry
gpshead Mar 15, 2026
c9ce9f8
Merge branch 'main' into traceback-timestamps
gpshead Mar 15, 2026
afa13d4
Merge branch 'main' into traceback-timestamps
gpshead Mar 15, 2026
5e81269
Remove incorrect "default if no value provided" from timestamp docs
gpshead Mar 15, 2026
1a44bc4
Greatly simplify test_traceback_timestamps
gpshead Mar 15, 2026
aa971bc
inherit -X traceback_timestamps in multiprocessing spawned children
gpshead Mar 15, 2026
13fa0d1
test that -X traceback_timestamps goes to spawned pythons
gpshead Mar 16, 2026
46bbb87
don't let strip_exc_timestamps be conditional, it processes data from…
gpshead Mar 16, 2026
4c838a2
fix xoptions help sort order
gpshead Mar 16, 2026
681948c
CI fix: windows line endings bring joy
gpshead Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ubuntu 24.04 not 22.04
  • Loading branch information
@gpshead
gpshead committed Mar 15, 2026
commit d9f6500d7bdaf7ca382d53db76d85ca0fd7a9473
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ jobs:
bolt-optimizations: ${{ matrix.bolt }}
free-threading: ${{ matrix.free-threading }}
os: ${{ matrix.os }}
traceback_timestamps: ${{ matrix.os == 'ubuntu-22.04-arm' && matrix.bolt == false && 'ns' || '' }}
traceback_timestamps: ${{ matrix.os == 'ubuntu-24.04-arm' && matrix.bolt == false && 'ns' || '' }}
test-opts: ${{ matrix.test-opts || '' }}

build-ubuntu-ssltests:
Expand Down