Skip to content

gh-100239: replace BINARY_SUBSCR & family by BINARY_OP with oparg NB_SUBSCR #129379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iritkatriel wants to merge 11 commits into from
Closed

gh-100239: replace BINARY_SUBSCR & family by BINARY_OP with oparg NB_SUBSCR #129379

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c1e7681
gh-100239: replace BINARY_SUBSCR & family by BINARY_OP with oparg NB_…
iritkatriel Jan 25, 2025
44d19be
Merge remote-tracking branch 'upstream/main' into binary_subscr
iritkatriel Jan 28, 2025
a5b12bd
simplify
iritkatriel Jan 28, 2025
38830f0
global
iritkatriel Jan 28, 2025
e53d19a
Merge remote-tracking branch 'upstream/main' into binary_subscr
iritkatriel Jan 28, 2025
cf020ca
add note to exception in c-analyzer
iritkatriel Jan 28, 2025
316443a
fix optimizer
iritkatriel Jan 28, 2025
52ceec7
update comment
iritkatriel Jan 28, 2025
6bb9978
use tab
iritkatriel Jan 28, 2025
fa072fd
Merge branch 'main' into binary_subscr
iritkatriel Jan 28, 2025
b9bbd06
update pystats
iritkatriel Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify
  • Loading branch information
@iritkatriel
iritkatriel committed Jan 28, 2025
commit a5b12bd3b473aa15ecfd4ea66c1423062c9663aa
8 changes: 2 additions & 6 deletions Python/codegen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5306,23 +5306,19 @@ codegen_subscript(compiler *c, expr_ty e)
}
else {
VISIT(c, expr, e->v.Subscript.slice);
int op = 0;
switch (ctx) {
case Load:
ADDOP_I(c, loc, BINARY_OP, NB_SUBSCR);
break;
case Store:
op = STORE_SUBSCR; break;
ADDOP(c, loc, STORE_SUBSCR);
break;
case Del:
op = DELETE_SUBSCR; break;
ADDOP(c, loc, DELETE_SUBSCR);
break;
default:
Py_UNREACHABLE();
}
if (op) {
ADDOP(c, loc, op);
}
}
return SUCCESS;
}
Expand Down