Skip to content

gh-104400: pygettext: Prepare to replace TokenEater with a NodeVisitor#129672

Merged
AA-Turner merged 1 commit intopython:mainfrom
tomasr8:pygettext-prep
Feb 4, 2025
Merged

gh-104400: pygettext: Prepare to replace TokenEater with a NodeVisitor#129672
AA-Turner merged 1 commit intopython:mainfrom
tomasr8:pygettext-prep

Conversation

@tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Feb 4, 2025 •
edited by bedevere-app bot
Loading

Preparatory PR to keep the diff of #104402 as small as possible.

  • Updates the module docstring
  • Moves key_for inside the class
  • Moves write_pot_file outside the class

cc @m-aciek

@tomasr8 tomasr8 requested a review from AA-Turner February 4, 2025 22:05
@bedevere-app bedevere-app bot mentioned this pull request Feb 4, 2025
Closed
AA-Turner
AA-Turner approved these changes Feb 4, 2025
View reviewed changes
@AA-Turner AA-Turner merged commit e41ec8e into python:main Feb 4, 2025
50 checks passed
@tomasr8 tomasr8 deleted the pygettext-prep branch February 4, 2025 23:06
@tomasr8
Copy link
Member Author

tomasr8 commented Feb 4, 2025

Thank you both for such a quick review!

@bedevere-bot
Copy link

bedevere-bot commented Feb 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit e41ec8e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/78/builds/8346) and take a look at the build logs.
  4. Check if the failure is related to this commit (e41ec8e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/78/builds/8346

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

@tomasr8
Copy link
Member Author

tomasr8 commented Feb 5, 2025

The buildbot failure does not seem related

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@tomasr8 @srinivasreddy
pythongh-104400: pygettext: Prepare to replace TokenEater with a Node…
a467d17 
…Visitor (python#129672)

* Update the module docstring
* Move ``key_for`` inside the class
* Move ``write_pot_file`` outside the class
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@tomasr8 @cmaloney
pythongh-104400: pygettext: Prepare to replace TokenEater with a Node…
779357a 
…Visitor (python#129672)

* Update the module docstring
* Move ``key_for`` inside the class
* Move ``write_pot_file`` outside the class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

+2 more reviewers

@J2085isa J2085isa J2085isa left review comments

@m-aciek m-aciek m-aciek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tomasr8 @bedevere-bot @AA-Turner @m-aciek @J2085isa