Skip to content

gh-129889: Support context manager protocol by contextvars.Token #129888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 13 commits into from
Feb 12, 2025
Merged

gh-129889: Support context manager protocol by contextvars.Token #129888

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c214680
Implement context manager for Token
asvetlov Jan 3, 2025
78cde56
Merge branch 'main' into cm_token
asvetlov Jan 19, 2025
3a04017
Merge branch 'main' into cm_token
asvetlov Feb 9, 2025
0400e8e
Use clinic for stubs generation
asvetlov Feb 9, 2025
61abb23
Update docs
asvetlov Feb 9, 2025
e2b6922
Merge remote-tracking branch 'upstream/main' into cm_token
asvetlov Feb 9, 2025
191f7a1
fix
asvetlov Feb 9, 2025
0287e78
More tests
asvetlov Feb 9, 2025
4e09df8
Fix test
asvetlov Feb 9, 2025
12be23d
More tests
asvetlov Feb 9, 2025
d90c78e
Add news
asvetlov Feb 10, 2025
fe006d3
Merge branch 'main' into cm_token
asvetlov Feb 10, 2025
a142ea4
Merge branch 'main' into cm_token
asvetlov Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@asvetlov
asvetlov committed Feb 9, 2025
commit 4e09df89fec8fc9b86d64879c505455b2f4e1a49
8 changes: 6 additions & 2 deletions Lib/test/test_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,13 @@ def test_token_contextmanager_reentrant(self):

def fun():
token = c.set(36)
with token:
with self.assertRaisesRegex(
RuntimeError,
"<Token .+ has already been used once"
):
with token:
self.assertEqual(c.get(), 36)
with token:
self.assertEqual(c.get(), 36)

self.assertEqual(c.get(), 42)

Expand Down
Loading