Skip to content

gh-130617 : fix time_clockid_converter on DragonFlyBSD#130634

Merged
vstinner merged 1 commit intopython:mainfrom
leleliu008:fix-130617
Feb 28, 2025
Merged

gh-130617 : fix time_clockid_converter on DragonFlyBSD#130634
vstinner merged 1 commit intopython:mainfrom
leleliu008:fix-130617

Conversation

@leleliu008
Copy link
Contributor

@leleliu008 leleliu008 commented Feb 27, 2025 •
edited by bedevere-app bot
Loading

@ghost
Copy link

ghost commented Feb 27, 2025 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Feb 27, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@leleliu008 leleliu008 changed the title fix time_clockid_converter on DragonFlyBSD gh-130617 : fix time_clockid_converter on DragonFlyBSD Feb 27, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 27, 2025
Closed
@vstinner vstinner added skip news needs backport to 3.13 bugs and security fixes labels Feb 27, 2025
@vstinner
Copy link
Member

vstinner commented Feb 27, 2025

You should sign the CLA: see the previous comment from the bot.

@leleliu008
Copy link
Contributor Author

leleliu008 commented Feb 27, 2025

You should sign the CLA: see the previous comment from the bot.

I can't open that url. I don't known if it has been blocked by the Chinese government.

@vstinner
Copy link
Member

vstinner commented Feb 27, 2025

I can't open that url. I don't known if it has been blocked by the Chinese government.

Can you open https://www.python.org/psf/contrib/contrib-form/ URL?

@leleliu008
Copy link
Contributor Author

leleliu008 commented Feb 27, 2025

I can't open that url. I don't known if it has been blocked by the Chinese government.

Can you open https://www.python.org/psf/contrib/contrib-form/ URL?

Yes. I can. I signed but the button didn't change.

@vstinner vstinner closed this Feb 27, 2025
@vstinner vstinner reopened this Feb 27, 2025
@vstinner
Copy link
Member

vstinner commented Feb 27, 2025

I signed but the button didn't change.

Thanks for signing. I'm not sure how to notify the bot that you signed the CLA :-) I tried to close/reopen the PR to trigger again CI jobs, but it didn't work.

@Mariatta
Copy link
Member

Mariatta commented Feb 27, 2025

@leleliu008 The Cla form on https://www.python.org/psf/contrib/contrib-form/ is not synced with the CLA Heroku database. Additionally the manual form could take a few days to check.

Do you perhaps have some kind of ad blocker, VPN or something like that on your computer? Could you try to turn those off, or try accessing the heroku link using a different device? We have other contributors from China before and haven't encountered this issue.

@leleliu008
Copy link
Contributor Author

leleliu008 commented Feb 28, 2025

@leleliu008 The Cla form on https://www.python.org/psf/contrib/contrib-form/ is not synced with the CLA Heroku database. Additionally the manual form could take a few days to check.

Do you perhaps have some kind of ad blocker, VPN or something like that on your computer? Could you try to turn those off, or try accessing the heroku link using a different device? We have other contributors from China before and haven't encountered this issue.

I ended up accessing that website through a VPN.

@leleliu008
gh-130617: fix time_clockid_converter on DragonFlyBSD
9eb5984 
Signed-off-by: leleliu008 <leleliu008@gmail.com>
@vstinner vstinner merged commit e419817 into python:main Feb 28, 2025
41 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 28, 2025

Thanks @leleliu008 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vstinner
Copy link
Member

vstinner commented Feb 28, 2025

Merged, thank you!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2025
@leleliu008 @miss-islington
pythongh-130617 : fix time_clockid_converter on DragonFlyBSD (pythonG…
774067a 
…H-130634)

(cherry picked from commit e419817)

Co-authored-by: leleliu008 <leleliu008@gmail.com>
Signed-off-by: leleliu008 <leleliu008@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 28, 2025

GH-130666 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 28, 2025
vstinner pushed a commit that referenced this pull request Feb 28, 2025
@miss-islington @leleliu008
[3.13] gh-130617 : fix time_clockid_converter on DragonFlyBSD (GH-130634
bafad85 
) (#130666)

gh-130617 : fix time_clockid_converter on DragonFlyBSD (GH-130634)
(cherry picked from commit e419817)

Signed-off-by: leleliu008 <leleliu008@gmail.com>
Co-authored-by: leleliu008 <leleliu008@gmail.com>
@collinfunk collinfunk mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build failed on DragonFlyBSD-6.4

3 participants

@leleliu008 @vstinner @Mariatta