Skip to content

GH-131358: Add encoding alias cseuckr for euc_kr#131370

Merged
corona10 merged 4 commits intopython:mainfrom
srinivasreddy:gh-131358
Mar 19, 2025
Merged

GH-131358: Add encoding alias cseuckr for euc_kr#131370
corona10 merged 4 commits intopython:mainfrom
srinivasreddy:gh-131358

Conversation

@srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Mar 17, 2025 •
edited by bedevere-app bot
Loading

@srinivasreddy srinivasreddy changed the title Add encoding alias cseuckr for euc_kr GH-131358: Add encoding alias cseuckr for euc_kr Mar 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 17, 2025
Closed
@srinivasreddy @picnixz
Update Misc/NEWS.d/next/Library/2025-03-17-21-35-53.gh-issue-131358.Y…
bb2a2dd 
…VZ6yo.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
corona10
corona10 reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am quite surprise that there is the existence of cseuckr..

@picnixz
Copy link
Member

picnixz commented Mar 18, 2025

FTR, it's documented in https://developer.mozilla.org/en-US/docs/Web/API/Encoding_API/Encodings so I guess it can exist in the wild?

@corona10
Copy link
Member

corona10 commented Mar 18, 2025

I believe that it's a very old encoding (except the banking system), and even if they use euc-kr, they designate the encoding euc-kr or cp949 (at Windows), not cseuckr.

@corona10
Copy link
Member

corona10 commented Mar 18, 2025

I am not sure it's worth adding it because we don't support all aliases that are listed on the JDK or Mozilla page.
(e.g ks_c_5601-1989)

@methane Do you have any ideas with this issue?

@corona10 corona10 self-assigned this Mar 18, 2025
@corona10
Copy link
Member

corona10 commented Mar 18, 2025

For example, there is also csEUCJP...

@methane
Copy link
Member

methane commented Mar 19, 2025

alias is imported by all Python programs. So I don't like adding everything in alias.

But in case of csEUCKR, it is used in real world.

I'm OK to adding it.

@corona10 corona10 merged commit 7558980 into python:main Mar 19, 2025
43 checks passed
@srinivasreddy srinivasreddy deleted the gh-131358 branch March 19, 2025 09:52
colesbury pushed a commit to colesbury/cpython that referenced this pull request Mar 20, 2025
@srinivasreddy @picnixz @colesbury
pythonGH-131358: Add encoding alias cseuckr for euc_kr (python#131370)
dbd7e7e 
* Add encoding alias cseuckr for euc_kr

* Update Misc/NEWS.d/next/Library/2025-03-17-21-35-53.gh-issue-131358.YVZ6yo.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

---------

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@methane methane mentioned this pull request Apr 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@methane methane methane approved these changes

@corona10 corona10 corona10 approved these changes

Assignees

@corona10 corona10

Labels

topic-unicode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srinivasreddy @picnixz @corona10 @methane