Skip to content

gh-132017: Handle SIGCONT in pyrepl#132918

Merged
pablogsal merged 2 commits intopython:mainfrom
StanFromIreland:repl-sigcont
May 5, 2025
Merged

gh-132017: Handle SIGCONT in pyrepl#132918
pablogsal merged 2 commits intopython:mainfrom
StanFromIreland:repl-sigcont

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Apr 25, 2025 •
edited
Loading

Not quite sure how to test this, manual testing passes.

cc @ambv

@bedevere-app bedevere-app bot mentioned this pull request Apr 25, 2025
Closed
@ZeroIntensity ZeroIntensity added the topic-repl Related to the interactive shell label Apr 25, 2025
@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label May 5, 2025
@pablogsal pablogsal enabled auto-merge (squash) May 5, 2025 20:12
@pablogsal
Copy link
Member

pablogsal commented May 5, 2025

Thanks for your contribution @StanFromIreland 🚀

@pablogsal pablogsal merged commit e4561da into python:main May 5, 2025
48 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented May 5, 2025

Thanks @StanFromIreland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

miss-islington-app bot commented May 5, 2025

Sorry, @StanFromIreland and @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e4561da886717ddd01ab0970452a14a1531e874d 3.13

@StanFromIreland StanFromIreland deleted the repl-sigcont branch May 5, 2025 20:43
@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 5, 2025

I will backport for you:-)

@bedevere-app
Copy link

bedevere-app bot commented May 5, 2025

GH-133470 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 5, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request May 5, 2025
@StanFromIreland
pythongh-132017: Handle SIGCONT in pyrepl (python#132918)
1834852 
(cherry picked from commit e4561da)

# Conflicts:
#	Lib/_pyrepl/unix_console.py
pablogsal pushed a commit that referenced this pull request May 5, 2025
@StanFromIreland
[3.13] gh-132017: Handle SIGCONT in pyrepl (#132918) (#133470)
1dfe5de
@bedevere-bot
Copy link

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.13 (tier-3) has failed when building commit 1dfe5de.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1386/builds/1287) and take a look at the build logs.
  4. Check if the failure is related to this commit (1dfe5de) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1386/builds/1287

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 18, done.        
remote: Counting objects:   5% (1/18)        
remote: Counting objects:  11% (2/18)        
remote: Counting objects:  16% (3/18)        
remote: Counting objects:  22% (4/18)        
remote: Counting objects:  27% (5/18)        
remote: Counting objects:  33% (6/18)        
remote: Counting objects:  38% (7/18)        
remote: Counting objects:  44% (8/18)        
remote: Counting objects:  50% (9/18)        
remote: Counting objects:  55% (10/18)        
remote: Counting objects:  61% (11/18)        
remote: Counting objects:  66% (12/18)        
remote: Counting objects:  72% (13/18)        
remote: Counting objects:  77% (14/18)        
remote: Counting objects:  83% (15/18)        
remote: Counting objects:  88% (16/18)        
remote: Counting objects:  94% (17/18)        
remote: Counting objects: 100% (18/18)        
remote: Counting objects: 100% (18/18), done.        
remote: Compressing objects:  11% (1/9)        
remote: Compressing objects:  22% (2/9)        
remote: Compressing objects:  33% (3/9)        
remote: Compressing objects:  44% (4/9)        
remote: Compressing objects:  55% (5/9)        
remote: Compressing objects:  66% (6/9)        
remote: Compressing objects:  77% (7/9)        
remote: Compressing objects:  88% (8/9)        
remote: Compressing objects: 100% (9/9)        
remote: Compressing objects: 100% (9/9), done.        
remote: Total 10 (delta 8), reused 3 (delta 1), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    3.13       -> FETCH_HEAD
Note: switching to '1dfe5def081bf8e05706df4cbd6b5590e191e70b'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1dfe5def081 [3.13] gh-132017: Handle SIGCONT in `pyrepl` (#132918) (#133470)
Switched to and reset branch '3.13'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

make: *** [testios] Terminated: 15

@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 5, 2025

Unrelated, and odd.

@mhsmith
Copy link
Member

mhsmith commented May 6, 2025

@freakboy3742: This has happened a couple of times this week, the iOS tests freezing in test_socket:

Any idea of the cause? It doesn't seem to be related to the known subinterpreters issue.

@freakboy3742
Copy link
Contributor

freakboy3742 commented May 6, 2025

Any idea of the cause? It doesn't seem to be related to the known subinterpreters issue.

Yeah - that's a new one for me... and it's going to be a PITA to track down with no stack trace... ☹️

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-132017: Handle SIGCONT in pyrepl (python#132918)
112421b
@salty-horse salty-horse mentioned this pull request Sep 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

@pablogsal pablogsal

Labels

topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@StanFromIreland @pablogsal @bedevere-bot @mhsmith @freakboy3742 @ZeroIntensity