Skip to content

gh-133304: workaround for RISC-V in PyFloat_Pack4/Unpack4()#133328

Merged
vstinner merged 4 commits intopython:mainfrom
skirpichev:wa-risc-v/133304
May 3, 2025
Merged

gh-133304: workaround for RISC-V in PyFloat_Pack4/Unpack4()#133328
vstinner merged 4 commits intopython:mainfrom
skirpichev:wa-risc-v/133304

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented May 3, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 3, 2025
Closed
@skirpichev

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@skirpichev

This comment was marked as resolved.

Sign in to view
@bedevere-bot
Copy link

bedevere-bot commented May 3, 2025

🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 6fdf4a6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133328%2Fmerge

The command will test the builders whose names match following regular expression: risc

The builders matched are:

  • riscv64 Ubuntu23 PR

@skirpichev

This comment was marked as resolved.

Sign in to view
@bedevere-bot
Copy link

bedevere-bot commented May 3, 2025

🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 6fdf4a6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133328%2Fmerge

The command will test the builders whose names match following regular expression: x86

The builders matched are:

  • x86 Debian Non-Debug with X PR
  • x86-64 MacOS Intel NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • x86-64 macOS PR
  • x86 Debian Installed with X PR

@skirpichev skirpichev changed the title gh-133304: workaround for RISC-V in PyFloat_Pack4() gh-133304: workaround for RISC-V in PyFloat_Pack4/Unpack4() May 3, 2025
@skirpichev skirpichev added the 3.14 bugs and security fixes label May 3, 2025
@skirpichev skirpichev marked this pull request as ready for review May 3, 2025 07:16
@skirpichev skirpichev requested a review from vstinner May 3, 2025 07:19
vstinner
vstinner reviewed May 3, 2025
View reviewed changes
@skirpichev

This comment was marked as resolved.

Sign in to view
@bedevere-bot
Copy link

bedevere-bot commented May 3, 2025

🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 48a1041 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133328%2Fmerge

The command will test the builders whose names match following regular expression: risc

The builders matched are:

  • riscv64 Ubuntu23 PR

@skirpichev skirpichev requested a review from vstinner May 3, 2025 12:07
vstinner
vstinner approved these changes May 3, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but does it work on Risc-V? :-) I didn't check buildbot.

@vstinner
Copy link
Member

vstinner commented May 3, 2025

buildbot/riscv64 Ubuntu23 PR — Build done.

Ah yes, it works!

@vstinner vstinner merged commit f16f06f into python:main May 3, 2025
47 checks passed
@vstinner
Copy link
Member

vstinner commented May 3, 2025

Merged, thanks.

@bedevere-bot
Copy link

bedevere-bot commented May 3, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x (tier-3) has failed when building commit f16f06f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1380/builds/3527) and take a look at the build logs.
  4. Check if the failure is related to this commit (f16f06f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1380/builds/3527

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/7530802D-F7A4-40FF-B2FD-EF3A1E801DFC/data/Containers/Bundle/Application/F956122D-DAEA-4A16-9C11-0BE94ECD7522/iOSTestbed.app/python/lib/python3.14/threading.py", line 1079, in _bootstrap_inner
    self._context.run(self.run)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/7530802D-F7A4-40FF-B2FD-EF3A1E801DFC/data/Containers/Bundle/Application/F956122D-DAEA-4A16-9C11-0BE94ECD7522/iOSTestbed.app/python/lib/python3.14/threading.py", line 1021, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/7530802D-F7A4-40FF-B2FD-EF3A1E801DFC/data/Containers/Bundle/Application/F956122D-DAEA-4A16-9C11-0BE94ECD7522/iOSTestbed.app/python/lib/python3.14/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/Users/buildbot/Library/Developer/XCTestDevices/7530802D-F7A4-40FF-B2FD-EF3A1E801DFC/data/Containers/Bundle/Application/F956122D-DAEA-4A16-9C11-0BE94ECD7522/iOSTestbed.app/python/lib/python3.14/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

@bedevere-bot
Copy link

bedevere-bot commented May 3, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x (tier-3) has failed when building commit f16f06f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/2219) and take a look at the build logs.
  4. Check if the failure is related to this commit (f16f06f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/2219

Summary of the results of the build (if available):

Click to see traceback logs 
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/base_events.py", line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/android/buildarea/3.x.mhsmith-android-aarch64/build/Android/android.py", line 530, in run_testbed
    async with asyncio.TaskGroup() as tg:
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/taskgroups.py", line 134, in __aexit__
    raise propagate_cancellation_error
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/taskgroups.py", line 110, in __aexit__
    await self._on_completed_fut
asyncio.exceptions.CancelledError

@skirpichev skirpichev deleted the wa-risc-v/133304 branch May 4, 2025 02:26
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@skirpichev @Pranjal095
pythongh-133304: workaround for RISC-V in PyFloat_Pack4/Unpack4() (py…
9c7a3af 
…thon#133328)
@skirpichev skirpichev mentioned this pull request Nov 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

3.14 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev @bedevere-bot @vstinner