Skip to content

gh-133597: Fix memory leak if error occurred in _sys_getwindowsversion_from_kernel32 #133598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 3 commits into from
May 8, 2025
Merged

gh-133597: Fix memory leak if error occurred in _sys_getwindowsversion_from_kernel32 #133598

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18cf3a2
Fix memory leak if error occured in _sys_getwindowsversion_from_kernel32
sergey-miryanov May 7, 2025
06f9db8
Merge branch 'main' into fix_memory_leak_sys_getwindowsversion_from_k…
Eclips4 May 7, 2025
f9daa4a
Merge branch 'main' into fix_memory_leak_sys_getwindowsversion_from_k…
zware May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix memory leak if error occured in _sys_getwindowsversion_from_kernel32
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed May 7, 2025
commit 18cf3a27e66dc2e1094dace085d9b41ec122df12
3 changes: 3 additions & 0 deletions Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,6 +1670,9 @@ _sys_getwindowsversion_from_kernel32(void)
!GetFileVersionInfoW(kernel32_path, 0, verblock_size, verblock) ||
!VerQueryValueW(verblock, L"", (LPVOID)&ffi, &ffi_len)) {
PyErr_SetFromWindowsErr(0);
if (verblock) {
PyMem_RawFree(verblock);
}
return NULL;
}

Expand Down
Loading