Skip to content

gh-133684: Fix get_annotations() where PEP 563 is involved #133795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 5 commits into from
May 25, 2025
Merged

gh-133684: Fix get_annotations() where PEP 563 is involved #133795

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1563a8d
gh-133684: Fix get_annotations() where PEP 563 is involved
JelleZijlstra May 10, 2025
9fb7488
simplify
JelleZijlstra May 10, 2025
54fd9f8
add comment
JelleZijlstra May 14, 2025
2afb851
more subtest
JelleZijlstra May 14, 2025
e05c569
Merge remote-tracking branch 'upstream/main' into getannos
JelleZijlstra May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed May 14, 2025
commit 54fd9f835d74d9deb9b3f8fab34613cab9a7a1ab
3 changes: 3 additions & 0 deletions Lib/annotationlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,6 +1050,9 @@ def _get_dunder_annotations(obj):

Does not return a fresh dictionary.
"""
# This special case is needed to support types defined under
# from __future__ import annotations, where accessing the __annotations__
# attribute directly might return annotations for the wrong class.
if isinstance(obj, type):
try:
ann = _BASE_GET_ANNOTATIONS(obj)
Expand Down