Skip to content

[3.13] gh-133745: Fix asyncio task factory name/context kwarg breaks #133948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 17 commits into from
May 18, 2025
Merged

[3.13] gh-133745: Fix asyncio task factory name/context kwarg breaks #133948

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5c3c953
gh-133745: Fix asyncio task factory name/context kwarg breaks
graingert May 12, 2025
6247a57
expect failure on named eager tasks
graingert May 12, 2025
ddfbeb2
remove failing test
graingert May 13, 2025
9dcf0e8
use only one try/finally/del block
graingert May 13, 2025
d607230
remove extra whitespace
graingert May 13, 2025
f9786ce
Merge branch '3.13' into fix-name-passed-to-task-factory
graingert May 13, 2025
36e8f04
Merge branch '3.13' into fix-name-passed-to-task-factory
graingert May 14, 2025
ac5759a
📜🤖 Added by blurb_it.
blurb-it[bot] May 14, 2025
363d336
copy editing for news
graingert May 14, 2025
2fd6255
Merge branch '3.13' into fix-name-passed-to-task-factory
graingert May 17, 2025
2ba0d19
update docs about create_task
graingert May 17, 2025
2e7556d
Discard changes to Doc/library/asyncio-task.rst
graingert May 17, 2025
d3021ae
add pass through docs
graingert May 17, 2025
b26c1ff
Update Doc/library/asyncio-eventloop.rst
graingert May 17, 2025
8088dac
Update Doc/library/asyncio-eventloop.rst
graingert May 17, 2025
5c26ed7
Apply suggestions from code review
graingert May 18, 2025
d600dd7
Apply suggestions from code review
graingert May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add pass through docs
  • Loading branch information
@graingert
graingert committed May 17, 2025
commit d3021aee2b5d894bb70fa8b7f44b53d465c377f5
6 changes: 6 additions & 0 deletions Doc/library/asyncio-eventloop.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,12 @@ Creating Futures and Tasks
for interoperability. In this case, the result type is a subclass
of :class:`Task`.

The arguments shown above are merely the most common ones, described below
The full function signature is largely the same as that of the
:class:`Task` constructor (or factory) - all of the keyword arguments to
this function are passed through to that interface, except *name*,
or *context* if it is ``None``.

If the *name* argument is provided and not ``None``, it is set as
the name of the task using :meth:`Task.set_name`.

Expand Down
Loading