Skip to content

gh-134155: fix AttributeError in email._header_value_parser.get_address #134194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitdancer merged 11 commits into from
Jun 5, 2025
Merged

gh-134155: fix AttributeError in email._header_value_parser.get_address #134194

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5c3fa11
Fix handling of empty strings in .get_dtext, .get_qp_ctext and .get_q…
sergey-miryanov May 18, 2025
61fc402
Fix appending of error while parsing domain literal
sergey-miryanov May 18, 2025
a3fe3e7
Add news entry
sergey-miryanov May 18, 2025
5174b65
Update Misc/NEWS.d/next/Library/2025-05-18-23-46-21.gh-issue-134152.3…
sergey-miryanov May 19, 2025
cf0a4ea
Revert "Fix handling of empty strings in .get_dtext, .get_qp_ctext an…
sergey-miryanov May 19, 2025
1ff7bcb
Merge branch 'gh-134152-fix-unbound-local-error-in-email' of github.c…
sergey-miryanov May 19, 2025
ce7e373
Merge branch 'main' into gh-134152-fix-unbound-local-error-in-email
hugovk May 26, 2025
ab4de0d
Add extra test for get_address
sergey-miryanov May 26, 2025
848a218
Merge branch 'main' into gh-134152-fix-unbound-local-error-in-email
sergey-miryanov May 26, 2025
ff5d410
Don't lost opening bracket in get_domain_literal
sergey-miryanov May 26, 2025
be40930
Tweak new tests for get_address
sergey-miryanov May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add extra test for get_address
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed May 26, 2025
commit ab4de0d9fe47d74b1f67fe2614b112cace75b654
18 changes: 18 additions & 0 deletions Lib/test/test_email/test__header_value_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2491,6 +2491,24 @@ def test_get_address_quoted_strings_in_atom_list(self):
self.assertEqual(address.all_mailboxes[0].domain, 'example.com')
self.assertEqual(address.all_mailboxes[0].addr_spec, '"example example"@example.com')

def test_get_address_with_invalid_domain(self):
address = parser.get_address("<T@[")
self.assertEqual(len(address), 2)
self.assertEqual(address[0].token_type, 'address')
self.assertEqual(address[0].all_mailboxes[0].local_part, 'T')
self.assertEqual(address[0].all_mailboxes[0].domain, ']')
self.assertEqual(address[0].all_mailboxes[0].addr_spec, 'T@]')
self.assertEqual(str(address[0].all_defects[0]), "missing trailing '>' on angle-addr")
self.assertEqual(str(address[0].all_defects[1]), "end of input inside domain-literal")

address = parser.get_address("!an??:=m==fr2@[C")
self.assertEqual(len(address), 2)
self.assertEqual(address[0].token_type, 'address')
self.assertEqual(address[0].all_mailboxes[0].local_part, '=m==fr2')
self.assertEqual(address[0].all_mailboxes[0].domain, '[C]')
self.assertEqual(address[0].all_mailboxes[0].addr_spec, '=m==fr2@[C]')
self.assertEqual(str(address[0].all_defects[0]), "end of header in group")
self.assertEqual(str(address[0].all_defects[1]), "end of input inside domain-literal")

# get_address_list

Expand Down